[pdal-commits] [PDAL/PDAL] f5f526: better error handling, as per #927

[GitHub]

  Branch: refs/heads/sqlite_error_handling
  Home:   https://github.com/PDAL/PDAL
  Commit: f5f52667abb7487a2db7e51adbf0764b14c0a3c0
      https://github.com/PDAL/PDAL/commit/f5f52667abb7487a2db7e51adbf0764b14c0a3c0
  Author: Michael P. Gerlek <mpg at flaxen.com>
  Date:   2015-05-26 (Tue, 26 May 2015)

  Changed paths:
    M plugins/sqlite/io/SQLiteCommon.hpp
    M plugins/sqlite/io/SQLiteReader.cpp
    M plugins/sqlite/io/SQLiteWriter.cpp

  Log Message:
  -----------
  better error handling, as per #927

made return codes and error handling consistent

removed derived exception types

added missing finalize() call (which caused random crashes), and
enforced resetting of m_statement (which is shared between insert() and
query())

(nothing readily unit-testable)


  Commit: 0d383c66f96be48fcda66dd7721be4942dcbfc6f
      https://github.com/PDAL/PDAL/commit/0d383c66f96be48fcda66dd7721be4942dcbfc6f
  Author: Michael P. Gerlek <mpg at flaxen.com>
  Date:   2015-05-26 (Tue, 26 May 2015)

  Changed paths:
    M plugins/sqlite/test/SQLiteTest.cpp

  Log Message:
  -----------
  explicitly scope the database read & write

otherwise we can’t be assured the dtors will be called so the files get
closed out properly


Compare: https://github.com/PDAL/PDAL/compare/f5f52667abb7^...0d383c66f96b