[pdal-commits] [PDAL/PDAL] e41d19: Fix UB caused by incrementing pass-the-end iterato...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/PDAL/PDAL
  Commit: e41d193900cb1099d43b2f30d435e303f122cfd6
      https://github.com/PDAL/PDAL/commit/e41d193900cb1099d43b2f30d435e303f122cfd6
  Author: Mateusz Łoskot <mateusz at loskot.net>
  Date:   2016-02-17 (Wed, 17 Feb 2016)

  Changed paths:
    M include/pdal/util/Utils.hpp

  Log Message:
  -----------
  Fix UB caused by incrementing pass-the-end iterator

Iterator returned from std::find_if may point pass-the-end,
but incrementing pass-the-end iterator is an undefined behaviour.

The bug was revealed by stringsplit case of the OptionsTest,
as well as UtilsTest, where final std::find_if returns end
iterator which must not be incremented.


  Commit: 37b3f35e75ef8fd52c66f789d6c1b35460a81bdf
      https://github.com/PDAL/PDAL/commit/37b3f35e75ef8fd52c66f789d6c1b35460a81bdf
  Author: Andrew Bell <andrew.bell.ia at gmail.com>
  Date:   2016-02-17 (Wed, 17 Feb 2016)

  Changed paths:
    M include/pdal/util/Utils.hpp

  Log Message:
  -----------
  Merge pull request #1129 from mloskot/ml/fix-utils-split2-ub

Fix UB caused by incrementing pass-the-end iterator


Compare: https://github.com/PDAL/PDAL/compare/476ff90bbe65...37b3f35e75ef