[pdal-commits] [PDAL/PDAL] dccc0e: remove win32 boost stuff now that boost is gone

GitHub noreply at github.com
Wed Feb 17 13:19:57 PST 2016


  Branch: refs/tags/docker-master
  Home:   https://github.com/PDAL/PDAL
  Commit: dccc0e0936e2321f64fd63dcd971a7679cd1a2f4
      https://github.com/PDAL/PDAL/commit/dccc0e0936e2321f64fd63dcd971a7679cd1a2f4
  Author: Howard Butler <howard at hobu.co>
  Date:   2016-02-16 (Tue, 16 Feb 2016)

  Changed paths:
    M cmake/win32_compiler_options.cmake

  Log Message:
  -----------
  remove win32 boost stuff now that boost is gone


  Commit: 329d5d397a92522e3ec27e01ed4e00abbb74f870
      https://github.com/PDAL/PDAL/commit/329d5d397a92522e3ec27e01ed4e00abbb74f870
  Author: Howard Butler <howard at hobu.co>
  Date:   2016-02-16 (Tue, 16 Feb 2016)

  Changed paths:
    M include/pdal/util/Utils.hpp

  Log Message:
  -----------
  include cstdint for Utils.hpp


  Commit: 5b2c96a66e6ee5d0d398531dbedcd2c1a18523c3
      https://github.com/PDAL/PDAL/commit/5b2c96a66e6ee5d0d398531dbedcd2c1a18523c3
  Author: Mateusz Łoskot <mateusz at loskot.net>
  Date:   2016-02-16 (Tue, 16 Feb 2016)

  Changed paths:
    M CMakeLists.txt

  Log Message:
  -----------
  GEOS is no longer optional

geos.cmake specifies REQUIRED property


  Commit: 03fbbcf95a0ee0b8db61496337a7d2249682bf3b
      https://github.com/PDAL/PDAL/commit/03fbbcf95a0ee0b8db61496337a7d2249682bf3b
  Author: Mateusz Łoskot <mateusz at loskot.net>
  Date:   2016-02-16 (Tue, 16 Feb 2016)

  Changed paths:
    M include/pdal/UserCallback.hpp

  Log Message:
  -----------
  Add missing #include <algorithm>

Required by std::max.


  Commit: f38dac117862144ece3d51f97c166947484662b3
      https://github.com/PDAL/PDAL/commit/f38dac117862144ece3d51f97c166947484662b3
  Author: Howard Butler <howard at hobu.co>
  Date:   2016-02-16 (Tue, 16 Feb 2016)

  Changed paths:
    M include/pdal/UserCallback.hpp

  Log Message:
  -----------
  Merge pull request #1124 from mloskot/ml/include-algorithm

Add missing #include <algorithm>


  Commit: e7969d227cfe68ec9b7fc995e7247f0da515f029
      https://github.com/PDAL/PDAL/commit/e7969d227cfe68ec9b7fc995e7247f0da515f029
  Author: Howard Butler <howard at hobu.co>
  Date:   2016-02-16 (Tue, 16 Feb 2016)

  Changed paths:
    M CMakeLists.txt

  Log Message:
  -----------
  Merge pull request #1123 from mloskot/ml/geos-optional

GEOS is no longer optional


  Commit: 15270e626d9b1d0d516087af9ee40c40042a8083
      https://github.com/PDAL/PDAL/commit/15270e626d9b1d0d516087af9ee40c40042a8083
  Author: Mateusz Łoskot <mateusz at loskot.net>
  Date:   2016-02-17 (Wed, 17 Feb 2016)

  Changed paths:
    M io/ilvis2/Ilvis2MetadataReader.cpp

  Log Message:
  -----------
  Remove variable-length array use from ILVIS2 reader

Fixes compilation using Visual C++ which has no support for
C99 VLAs


  Commit: 9eb0e6218f5f73ef8d9a393e56713659923201f4
      https://github.com/PDAL/PDAL/commit/9eb0e6218f5f73ef8d9a393e56713659923201f4
  Author: Mateusz Łoskot <mateusz at loskot.net>
  Date:   2016-02-17 (Wed, 17 Feb 2016)

  Changed paths:
    M cmake/win32_compiler_options.cmake

  Log Message:
  -----------
  Defined BOOST_ALL_NO_LIB to disable auto-linking

Fixes linker errors about missing pdalboost_filesystem...lib
and others, while building with Visual Studio.


  Commit: 163f9e0bf022c7c4b5383b87d2b3007653955fde
      https://github.com/PDAL/PDAL/commit/163f9e0bf022c7c4b5383b87d2b3007653955fde
  Author: Andrew Bell <andrew.bell.ia at gmail.com>
  Date:   2016-02-17 (Wed, 17 Feb 2016)

  Changed paths:
    M io/ilvis2/Ilvis2MetadataReader.cpp

  Log Message:
  -----------
  Merge pull request #1125 from mloskot/ml/ilvis2-fix-vla

Remove variable-length array use from ILVIS2 reader


  Commit: 97fc159ef5f0b9236e1bad378eacff2a4064abdb
      https://github.com/PDAL/PDAL/commit/97fc159ef5f0b9236e1bad378eacff2a4064abdb
  Author: Mateusz Łoskot <mateusz at loskot.net>
  Date:   2016-02-17 (Wed, 17 Feb 2016)

  Changed paths:
    M CMakeLists.txt

  Log Message:
  -----------
  Define gtest_force_shared_crt for MSVC

Since tests link CRT dynamically (Visual C++ projects default),
we need to require gtest to link dynamically too.
Otherwise, tests fail to build due to linker error:
LNK2038: mismatch detected for 'RuntimeLibrary':
value 'MTd_StaticDebug' doesn't match value 'MDd_DynamicDebug'


  Commit: 9b764ff0f27ad750a1744879150c27f8145fa892
      https://github.com/PDAL/PDAL/commit/9b764ff0f27ad750a1744879150c27f8145fa892
  Author: Howard Butler <howard at hobu.co>
  Date:   2016-02-17 (Wed, 17 Feb 2016)

  Changed paths:
    M cmake/win32_compiler_options.cmake

  Log Message:
  -----------
  Merge pull request #1126 from mloskot/ml/msvc-disable-boost-autolink

Define BOOST_ALL_NO_LIB to disable auto-linking


  Commit: 476ff90bbe6503b9711547dccf1036a8dfa7c5bb
      https://github.com/PDAL/PDAL/commit/476ff90bbe6503b9711547dccf1036a8dfa7c5bb
  Author: Howard Butler <howard at hobu.co>
  Date:   2016-02-17 (Wed, 17 Feb 2016)

  Changed paths:
    M CMakeLists.txt

  Log Message:
  -----------
  Merge pull request #1127 from mloskot/ml/msvc-fix-gtest-linking

Define gtest_force_shared_crt for MSVC


  Commit: 51e0f721c8cf672b9f3a2cf9553909269a8c84f5
      https://github.com/PDAL/PDAL/commit/51e0f721c8cf672b9f3a2cf9553909269a8c84f5
  Author: Andrew Bell <andrew.bell.ia at gmail.com>
  Date:   2016-02-17 (Wed, 17 Feb 2016)

  Changed paths:
    M io/gdal/GDALReader.cpp
    M src/GDALUtils.cpp
    A test/data/gdal/byte.tif
    A test/data/gdal/data.xyz
    A test/data/gdal/float32.tif
    A test/data/gdal/float64.tif
    A test/data/gdal/int16.tif
    A test/data/gdal/int32.tif
    M test/unit/io/gdal/GDALReaderTest.cpp

  Log Message:
  -----------
  Fix GDAL reader so that tests pass :)
Test tif files from from GDAL autotest.  data.xyz file was generated from
float32.tif with gdal_translate.


  Commit: e41d193900cb1099d43b2f30d435e303f122cfd6
      https://github.com/PDAL/PDAL/commit/e41d193900cb1099d43b2f30d435e303f122cfd6
  Author: Mateusz Łoskot <mateusz at loskot.net>
  Date:   2016-02-17 (Wed, 17 Feb 2016)

  Changed paths:
    M include/pdal/util/Utils.hpp

  Log Message:
  -----------
  Fix UB caused by incrementing pass-the-end iterator

Iterator returned from std::find_if may point pass-the-end,
but incrementing pass-the-end iterator is an undefined behaviour.

The bug was revealed by stringsplit case of the OptionsTest,
as well as UtilsTest, where final std::find_if returns end
iterator which must not be incremented.


  Commit: 931c8ae7eac69220248c6df4fd0d13618b55af47
      https://github.com/PDAL/PDAL/commit/931c8ae7eac69220248c6df4fd0d13618b55af47
  Author: Mateusz Łoskot <mateusz at loskot.net>
  Date:   2016-02-17 (Wed, 17 Feb 2016)

  Changed paths:
    M src/util/Utils.cpp

  Log Message:
  -----------
  Fix out of range access bug in trimTrailing

If input string is empty, size()-1 overflows
causing character access beyond valid range.


  Commit: 37b3f35e75ef8fd52c66f789d6c1b35460a81bdf
      https://github.com/PDAL/PDAL/commit/37b3f35e75ef8fd52c66f789d6c1b35460a81bdf
  Author: Andrew Bell <andrew.bell.ia at gmail.com>
  Date:   2016-02-17 (Wed, 17 Feb 2016)

  Changed paths:
    M include/pdal/util/Utils.hpp

  Log Message:
  -----------
  Merge pull request #1129 from mloskot/ml/fix-utils-split2-ub

Fix UB caused by incrementing pass-the-end iterator


  Commit: 2b1eb3f514fea3f0e20921fc57c4714cb0d1f48d
      https://github.com/PDAL/PDAL/commit/2b1eb3f514fea3f0e20921fc57c4714cb0d1f48d
  Author: Andrew Bell <andrew.bell.ia at gmail.com>
  Date:   2016-02-17 (Wed, 17 Feb 2016)

  Changed paths:
    M src/util/Utils.cpp

  Log Message:
  -----------
  Merge pull request #1130 from mloskot/ml/fix-trim

Fix out of range access bug in trimTrailing


  Commit: bbb283471071564d1e71e25ef3dc1e94162c1bca
      https://github.com/PDAL/PDAL/commit/bbb283471071564d1e71e25ef3dc1e94162c1bca
  Author: Mateusz Łoskot <mateusz at loskot.net>
  Date:   2016-02-17 (Wed, 17 Feb 2016)

  Changed paths:
    M test/unit/PDALUtilsTest.cpp

  Log Message:
  -----------
  Open output file in binary mode to avoid EOL translation.

Otherwise, on Windows, EOL is translated to CRLF and test
files do not compare as equal.


  Commit: d15222c41f95229cd40c3f9ca1486493cbf60d3c
      https://github.com/PDAL/PDAL/commit/d15222c41f95229cd40c3f9ca1486493cbf60d3c
  Author: Andrew Bell <andrew.bell.ia at gmail.com>
  Date:   2016-02-17 (Wed, 17 Feb 2016)

  Changed paths:
    M test/unit/PDALUtilsTest.cpp

  Log Message:
  -----------
  Merge pull request #1132 from mloskot/ml/fix-cmp-files-eol

Open output file in binary mode to avoid EOL translation.


  Commit: 3c54b01b51763292418246bfda53827e4507b003
      https://github.com/PDAL/PDAL/commit/3c54b01b51763292418246bfda53827e4507b003
  Author: Mateusz Łoskot <mateusz at loskot.net>
  Date:   2016-02-17 (Wed, 17 Feb 2016)

  Changed paths:
    M include/pdal/util/Uuid.hpp

  Log Message:
  -----------
  Fix too small sprintf buffer in Uuid::unparse

sprintf always appends terminating null character, so the character
buffer used with sprintf needs to accommodate it.


  Commit: 00a1ddf550b49429f7fc8c75837111dcd2ac753d
      https://github.com/PDAL/PDAL/commit/00a1ddf550b49429f7fc8c75837111dcd2ac753d
  Author: Andrew Bell <andrew.bell.ia at gmail.com>
  Date:   2016-02-17 (Wed, 17 Feb 2016)

  Changed paths:
    M include/pdal/util/Uuid.hpp

  Log Message:
  -----------
  Merge pull request #1133 from mloskot/ml/fix-uuid-buffer-overrun

Fix too small sprintf buffer in Uuid::unparse


  Commit: 98505f1184200a236cc273db467d4b23db704330
      https://github.com/PDAL/PDAL/commit/98505f1184200a236cc273db467d4b23db704330
  Author: Andrew Bell <andrew.bell.ia at gmail.com>
  Date:   2016-02-17 (Wed, 17 Feb 2016)

  Changed paths:
    M filters/crop/CropFilter.cpp
    M include/pdal/Polygon.hpp
    M src/Polygon.cpp

  Log Message:
  -----------
  Use standard error handling for stream failure of Polygon.
Remove unnecessary indirection for GEOS context.


  Commit: e76b229515a41b5cf7a2d891d0d5106042602659
      https://github.com/PDAL/PDAL/commit/e76b229515a41b5cf7a2d891d0d5106042602659
  Author: Howard Butler <howard at hobu.co>
  Date:   2016-02-17 (Wed, 17 Feb 2016)

  Changed paths:
    M filters/crop/CropFilter.cpp
    M include/pdal/Polygon.hpp
    M src/Polygon.cpp

  Log Message:
  -----------
  Merge pull request #1134 from PDAL/polycontext

Use standard error handling for stream failure of Polygon.


  Commit: e933b45d4510d1779219d0bc3441113a51d7b27c
      https://github.com/PDAL/PDAL/commit/e933b45d4510d1779219d0bc3441113a51d7b27c
  Author: Howard Butler <howard at hobu.co>
  Date:   2016-02-17 (Wed, 17 Feb 2016)

  Changed paths:
    M io/gdal/GDALReader.cpp
    M src/GDALUtils.cpp
    A test/data/gdal/byte.tif
    A test/data/gdal/data.xyz
    A test/data/gdal/float32.tif
    A test/data/gdal/float64.tif
    A test/data/gdal/int16.tif
    A test/data/gdal/int32.tif
    M test/unit/io/gdal/GDALReaderTest.cpp

  Log Message:
  -----------
  Merge pull request #1135 from PDAL/fixgdal

Fix GDAL reader so that tests pass


  Commit: 6c59449f8fc2b49199d4a6790b0e384c29ad1ab7
      https://github.com/PDAL/PDAL/commit/6c59449f8fc2b49199d4a6790b0e384c29ad1ab7
  Author: Howard Butler <howard at hobu.co>
  Date:   2016-02-17 (Wed, 17 Feb 2016)

  Changed paths:
    M apps/CMakeLists.txt
    M appveyor.yml
    M cmake/examples/hobu-config.sh
    M filters/reprojection/ReprojectionFilter.cpp
    M include/pdal/PDALUtils.hpp
    M include/pdal/util/ProgramArgs.hpp
    M include/pdal/util/Uuid.hpp
    M io/derivative/DerivativeWriter.cpp
    M kernels/diff/DiffKernel.cpp
    M kernels/diff/DiffKernel.hpp
    M kernels/split/SplitKernel.cpp
    M scripts/appveyor/config.cmd
    M scripts/docker/Dockerfile
    M scripts/docker/dependencies/Dockerfile
    M src/CMakeLists.txt
    M src/SpatialReference.cpp
    M src/util/FileUtils.cpp
    M test/unit/BoundsTest.cpp
    M test/unit/OptionsTest.cpp
    M test/unit/PointViewTest.cpp
    M test/unit/Support.cpp
    M tools/lasdump/CMakeLists.txt

  Log Message:
  -----------
  Roll up of a bunch of windows build improvements related to boost
removal.

* Get artifact upload working on AppVeyor
* A few Dockerfile improvements tossed in there too


Compare: https://github.com/PDAL/PDAL/compare/b4e4d52c5bbb...6c59449f8fc2


More information about the pdal-commits mailing list