[pdal-commits] [PDAL/PDAL] 416385: Fix out-of-bounds access in program args

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/PDAL/PDAL
  Commit: 416385bc5c359597a68c460d1ae7f0c2cc9da395
      https://github.com/PDAL/PDAL/commit/416385bc5c359597a68c460d1ae7f0c2cc9da395
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2016-11-07 (Mon, 07 Nov 2016)

  Changed paths:
    M include/pdal/util/ProgramArgs.hpp

  Log Message:
  -----------
  Fix out-of-bounds access in program args

If `i == m_vals.size() - 1`, consumed is passed `m_vals.size()`, which is
out-of-bounds. Bug discovered by a combination of MSVC compilation in
Debug mode and http://clang.llvm.org/docs/AddressSanitizer.html.


  Commit: 54a08f7e1d322683ce2c63adfb1002b52b718965
      https://github.com/PDAL/PDAL/commit/54a08f7e1d322683ce2c63adfb1002b52b718965
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2016-11-07 (Mon, 07 Nov 2016)

  Changed paths:
    M include/pdal/util/ProgramArgs.hpp

  Log Message:
  -----------
  Merge pull request #1358 from gadomski/out-of-bounds-access

Fix out-of-bounds access in program args


Compare: https://github.com/PDAL/PDAL/compare/437528f44a07...54a08f7e1d32