[pdal-commits] [PDAL/PDAL] 4680ee: Move some generic Eigen functions

GitHub noreply at github.com
Tue Nov 8 06:29:58 PST 2016 

  Branch: refs/heads/python-updates
  Home:   https://github.com/PDAL/PDAL
  Commit: 4680eed5de6b4991446a940912e1956de561b1b7
      https://github.com/PDAL/PDAL/commit/4680eed5de6b4991446a940912e1956de561b1b7
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2016-11-04 (Fri, 04 Nov 2016)

  Changed paths:
    M filters/mongus/MongusFilter.cpp
    M filters/mongus/MongusFilter.hpp
    M include/pdal/Eigen.hpp
    M src/Eigen.cpp

  Log Message:
  -----------
  Move some generic Eigen functions

Multiple implementations of things like Eigen matrix padding, opening, closing,
etc. have cropped up in multiple filters. They can safely live alongside our
growing collection of Eigen utility functions.


  Commit: e66c9efb02017642462d60ef9579cbe715508e01
      https://github.com/PDAL/PDAL/commit/e66c9efb02017642462d60ef9579cbe715508e01
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2016-11-07 (Mon, 07 Nov 2016)

  Changed paths:
    M filters/smrf/SMRFilter.cpp
    M filters/smrf/SMRFilter.hpp
    M include/pdal/Eigen.hpp
    M src/Eigen.cpp

  Log Message:
  -----------
  Improve the documentation about our new Eigen functions, apply Astyle, and
remove duplicates from SMRF


  Commit: 287f059e5c505a3d4404d8f494c7157c74e7b03f
      https://github.com/PDAL/PDAL/commit/287f059e5c505a3d4404d8f494c7157c74e7b03f
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2016-11-07 (Mon, 07 Nov 2016)

  Changed paths:
    M filters/mongus/MongusFilter.cpp
    M filters/smrf/SMRFilter.cpp
    M include/pdal/Eigen.hpp
    M include/pdal/util/Utils.hpp
    M io/derivative/DerivativeWriter.cpp
    M src/Eigen.cpp

  Log Message:
  -----------
  Move clamp to Utils and make it a template


  Commit: 40e275c3b283a7e68bcdd158ba5a3467fe2cf1e6
      https://github.com/PDAL/PDAL/commit/40e275c3b283a7e68bcdd158ba5a3467fe2cf1e6
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2016-11-07 (Mon, 07 Nov 2016)

  Changed paths:
    M filters/approximatecoplanar/ApproximateCoplanarFilter.cpp
    M filters/eigenvalues/EigenvaluesFilter.cpp
    M filters/estimaterank/EstimateRankFilter.cpp
    M filters/mongus/MongusFilter.cpp
    M filters/normal/NormalFilter.cpp
    M filters/smrf/SMRFilter.cpp
    M include/pdal/Eigen.hpp
    M src/Eigen.cpp
    M test/unit/EigenTest.cpp

  Log Message:
  -----------
  Our Eigen utilities should probably be namespaced


  Commit: 20790431c572adde585cb47a8cb103966bb37b3e
      https://github.com/PDAL/PDAL/commit/20790431c572adde585cb47a8cb103966bb37b3e
  Author: Bradley J Chambers <brad.chambers at gmail.com>
  Date:   2016-11-07 (Mon, 07 Nov 2016)

  Changed paths:
    M filters/approximatecoplanar/ApproximateCoplanarFilter.cpp
    M filters/eigenvalues/EigenvaluesFilter.cpp
    M filters/estimaterank/EstimateRankFilter.cpp
    M filters/mongus/MongusFilter.cpp
    M filters/normal/NormalFilter.cpp
    M filters/smrf/SMRFilter.cpp
    R include/pdal/Eigen.hpp
    A include/pdal/EigenUtils.hpp
    M src/CMakeLists.txt
    R src/Eigen.cpp
    A src/EigenUtils.cpp
    M test/unit/EigenTest.cpp

  Log Message:
  -----------
  Eigen should take cues from GDAL and GEOS and provide utilies in EigenUtils


  Commit: 416385bc5c359597a68c460d1ae7f0c2cc9da395
      https://github.com/PDAL/PDAL/commit/416385bc5c359597a68c460d1ae7f0c2cc9da395
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2016-11-07 (Mon, 07 Nov 2016)

  Changed paths:
    M include/pdal/util/ProgramArgs.hpp

  Log Message:
  -----------
  Fix out-of-bounds access in program args

If `i == m_vals.size() - 1`, consumed is passed `m_vals.size()`, which is
out-of-bounds. Bug discovered by a combination of MSVC compilation in
Debug mode and http://clang.llvm.org/docs/AddressSanitizer.html.


  Commit: 25db54608953c91160ec89898b4aa6241b6efe7f
      https://github.com/PDAL/PDAL/commit/25db54608953c91160ec89898b4aa6241b6efe7f
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2016-11-07 (Mon, 07 Nov 2016)

  Changed paths:
    M include/pdal/util/FileUtils.hpp
    M src/util/FileUtils.cpp

  Log Message:
  -----------
  Two windoze-specific fixes

PDAL_DLL modifier for `glob`, and include `Windows.h`.


  Commit: 437528f44a079077e36df5c33bf8d877fc4110a8
      https://github.com/PDAL/PDAL/commit/437528f44a079077e36df5c33bf8d877fc4110a8
  Author: chambbj <brad.chambers at gmail.com>
  Date:   2016-11-07 (Mon, 07 Nov 2016)

  Changed paths:
    M filters/approximatecoplanar/ApproximateCoplanarFilter.cpp
    M filters/eigenvalues/EigenvaluesFilter.cpp
    M filters/estimaterank/EstimateRankFilter.cpp
    M filters/mongus/MongusFilter.cpp
    M filters/mongus/MongusFilter.hpp
    M filters/normal/NormalFilter.cpp
    M filters/smrf/SMRFilter.cpp
    M filters/smrf/SMRFilter.hpp
    R include/pdal/Eigen.hpp
    A include/pdal/EigenUtils.hpp
    M include/pdal/util/Utils.hpp
    M io/derivative/DerivativeWriter.cpp
    M src/CMakeLists.txt
    R src/Eigen.cpp
    A src/EigenUtils.cpp
    M test/unit/EigenTest.cpp

  Log Message:
  -----------
  Merge pull request #1357 from PDAL/more-eigen-funcs

Eigen utility enhancements


  Commit: 54a08f7e1d322683ce2c63adfb1002b52b718965
      https://github.com/PDAL/PDAL/commit/54a08f7e1d322683ce2c63adfb1002b52b718965
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2016-11-07 (Mon, 07 Nov 2016)

  Changed paths:
    M include/pdal/util/ProgramArgs.hpp

  Log Message:
  -----------
  Merge pull request #1358 from gadomski/out-of-bounds-access

Fix out-of-bounds access in program args


  Commit: 425de8bdbbf32a8acd8ee4b5d6a5de8c6e036d8f
      https://github.com/PDAL/PDAL/commit/425de8bdbbf32a8acd8ee4b5d6a5de8c6e036d8f
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2016-11-07 (Mon, 07 Nov 2016)

  Changed paths:
    M test/unit/FileUtilsTest.cpp

  Log Message:
  -----------
  Close file after creation in glob test

Otherwise, on subsequent delete, Windoze complains about that file already
in use.

*Might* fix AppVeyor.


  Commit: 850135438e571fbb529134cdbf8f37fd97f7a210
      https://github.com/PDAL/PDAL/commit/850135438e571fbb529134cdbf8f37fd97f7a210
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2016-11-07 (Mon, 07 Nov 2016)

  Changed paths:
    M test/unit/FileUtilsTest.cpp

  Log Message:
  -----------
  Merge pull request #1362 from gadomski/glob-test

Close file after creation in glob test


  Commit: 0d4c0a2b5b16364145acd4b3f19e4e10af22d194
      https://github.com/PDAL/PDAL/commit/0d4c0a2b5b16364145acd4b3f19e4e10af22d194
  Author: Howard Butler <howard at hobu.co>
  Date:   2016-11-08 (Tue, 08 Nov 2016)

  Changed paths:
    M filters/approximatecoplanar/ApproximateCoplanarFilter.cpp
    M filters/eigenvalues/EigenvaluesFilter.cpp
    M filters/estimaterank/EstimateRankFilter.cpp
    M filters/mongus/MongusFilter.cpp
    M filters/mongus/MongusFilter.hpp
    M filters/normal/NormalFilter.cpp
    M filters/smrf/SMRFilter.cpp
    M filters/smrf/SMRFilter.hpp
    R include/pdal/Eigen.hpp
    A include/pdal/EigenUtils.hpp
    M include/pdal/util/FileUtils.hpp
    M include/pdal/util/ProgramArgs.hpp
    M include/pdal/util/Utils.hpp
    M io/derivative/DerivativeWriter.cpp
    M src/CMakeLists.txt
    R src/Eigen.cpp
    A src/EigenUtils.cpp
    M src/util/FileUtils.cpp
    M test/unit/EigenTest.cpp
    M test/unit/FileUtilsTest.cpp

  Log Message:
  -----------
  Merge remote-tracking branch 'origin/master' into python-updates


Compare: https://github.com/PDAL/PDAL/compare/b3ecee9f3698...0d4c0a2b5b16

More information about the pdal-commits mailing list