[pdal-commits] [PDAL/PDAL] fac127: Bump minimum cmake version to 2.8.12

GitHub noreply at github.com
Tue Nov 8 07:14:37 PST 2016


  Branch: refs/heads/master
  Home:   https://github.com/PDAL/PDAL
  Commit: fac127278ad52fdc066d89cb9ce9e51b272ccded
      https://github.com/PDAL/PDAL/commit/fac127278ad52fdc066d89cb9ce9e51b272ccded
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2016-11-08 (Tue, 08 Nov 2016)

  Changed paths:
    M CMakeLists.txt

  Log Message:
  -----------
  Bump minimum cmake version to 2.8.12


  Commit: 7b345096b9894e3fc88b34b4dd1e3e509eba704c
      https://github.com/PDAL/PDAL/commit/7b345096b9894e3fc88b34b4dd1e3e509eba704c
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2016-11-08 (Tue, 08 Nov 2016)

  Changed paths:
    M apps/CMakeLists.txt
    M cmake/macros.cmake
    M dimbuilder/CMakeLists.txt
    M doc/tutorial/using.rst
    M examples/writing-filter/CMakeLists.txt
    M examples/writing-kernel/CMakeLists.txt
    M examples/writing-reader/CMakeLists.txt
    M examples/writing-writer/CMakeLists.txt
    M examples/writing/CMakeLists.txt
    M src/plang/CMakeLists.txt
    M tools/lasdump/CMakeLists.txt
    M tools/nitfwrap/CMakeLists.txt

  Log Message:
  -----------
  Use PUBLIC or PRIVATE for all target_link_libraries

I choose PUBLIC or PRIVATE based on:

- If target is a library, choose PUBLIC
- If target is an executable, choose PRIVATE

This heuristic seemed to make sense for all of the changes as far as I
could tell, but maybe some libraries could have private dependencies. I
also updated the tutorials to use the same call signature.


  Commit: 30e9eaa1771a8d53edae2cf312d4b8f1d6d47bd7
      https://github.com/PDAL/PDAL/commit/30e9eaa1771a8d53edae2cf312d4b8f1d6d47bd7
  Author: Pete Gadomski <pete.gadomski at gmail.com>
  Date:   2016-11-08 (Tue, 08 Nov 2016)

  Changed paths:
    M CMakeLists.txt
    M apps/CMakeLists.txt
    M cmake/macros.cmake
    M dimbuilder/CMakeLists.txt
    M doc/tutorial/using.rst
    M examples/writing-filter/CMakeLists.txt
    M examples/writing-kernel/CMakeLists.txt
    M examples/writing-reader/CMakeLists.txt
    M examples/writing-writer/CMakeLists.txt
    M examples/writing/CMakeLists.txt
    M src/plang/CMakeLists.txt
    M tools/lasdump/CMakeLists.txt
    M tools/nitfwrap/CMakeLists.txt

  Log Message:
  -----------
  Merge pull request #1363 from gadomski/cmake-2.8.12

CMake 2.8.12 and target_link_libraries keyword signature


Compare: https://github.com/PDAL/PDAL/compare/850135438e57...30e9eaa1771a


More information about the pdal-commits mailing list