[pdal-commits] [PDAL/PDAL] 6b40cb: Fix CMake dependencies for Riegl RDB Plugin (#2219...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/PDAL/PDAL
  Commit: 6b40cb8cb6cfac286e3b940cad4184ed78c23b77
      https://github.com/PDAL/PDAL/commit/6b40cb8cb6cfac286e3b940cad4184ed78c23b77
  Author: Norbert Wenzel <norbertwenzel at users.noreply.github.com>
  Date:   2018-10-10 (Wed, 10 Oct 2018)

  Changed paths:
    M plugins/rdb/CMakeLists.txt

  Log Message:
  -----------
  Fix CMake dependencies for Riegl RDB Plugin (#2219)

* Remove explicit include directory setting

The linked target `rdbcpp` already sets `target_include_directories`.
CMake propagates these directories, so no use adding them again.

* Link to PDAL provided Eigen vendor library

The previously used CMake variable `EIGEN_INCLUDE_DIRS` was empty
when no Eigen library was installed. Since PDAL base lib is built
with `vendor/eigen` in any case, using the very same Eigen library
should be the safest option for a PDAL plugin.

* Add include directory for JSONCPP library

When JSONCPP is not installed ie. the include files are in a common
directory that is searched for library includes anyway, explicitly
setting the include directory is required.



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.