[pdal-commits] [PDAL/PDAL] 8cfa74: Default/override SRS options for all readers (#221...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/PDAL/PDAL
  Commit: 8cfa74929831ddea8080bd5a6b64dd36d238374e
      https://github.com/PDAL/PDAL/commit/8cfa74929831ddea8080bd5a6b64dd36d238374e
  Author: Connor Manning <connor at hobu.co>
  Date:   2018-10-15 (Mon, 15 Oct 2018)

  Changed paths:
    M io/BpfReader.cpp
    M io/EptReader.cpp
    M io/GDALReader.cpp
    M io/Ilvis2Reader.cpp
    M io/LasReader.cpp
    M io/OptechReader.cpp
    M io/TIndexReader.cpp
    M pdal/Reader.cpp
    M pdal/Reader.hpp
    M pdal/Stage.cpp
    M pdal/Stage.hpp
    M plugins/greyhound/io/GreyhoundReader.cpp
    M plugins/icebridge/io/IcebridgeReader.cpp
    M plugins/matlab/io/MatlabReader.cpp
    M plugins/pgpointcloud/io/PgReader.cpp
    M plugins/rdb/io/RdbReader.cpp
    M test/unit/SpatialReferenceTest.cpp

  Log Message:
  -----------
  Default/override SRS options for all readers (#2210)

* Add default_srs and override_srs reader options.  Make addSpatialReference apply this logic instead of each reader.

* Use addSynonym for override_srs/spatialreference args instead of double-registering.

* Handle default/override-SRS options in Reader.

* Remove addSpatialReferenceArg call from PgReader - this is now handled at the Reader level.

* Remove useless try/catch.

* Correct comment.

* Throw if both default and override SRS options are set.

* Debug log if setSpatialReference no-ops due to an override existing.

* Compare SRS directly in test, use quick-info output to test against.

* Naming.

* Isolate override/default SRS members to Reader.

* Use Srs::valid instead of negating Srs::empty.

* Maintain public visibility of Stage::setSpatialReference within derived Reader.



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.