[pdal-commits] [PDAL/PDAL] e8b42c: Write more glTF attributes, including color and no...

[Emma Krantz]

  Branch: refs/heads/master
  Home:   https://github.com/PDAL/PDAL
  Commit: e8b42c460baf6950051878034bb26edb85eaf0c7
      https://github.com/PDAL/PDAL/commit/e8b42c460baf6950051878034bb26edb85eaf0c7
  Author: Emma Krantz <3796838+KeyboardSounds at users.noreply.github.com>
  Date:   2020-05-07 (Thu, 07 May 2020)

  Changed paths:
    M io/GltfWriter.cpp
    M io/GltfWriter.hpp
    M test/unit/CMakeLists.txt
    A test/unit/io/GltfWriterTest.cpp

  Log Message:
  -----------
  Write more glTF attributes, including color and normals (#3043)

* Write point normals when using writer.gltf

When writing out gltf files, the normals for each point are now included in the vertex attributes. Also includes new tests for GltfWriter.

* Write point colours with writer.gltf

- GltfWriter now writes out point colors as COLOR_0 vertex attributes
- Cleanup of GltfWriter code.
- Improvement to GltfWriterTest tests.

* No longer default to writing out colors to gltf

Changed the default for gltf writer not write colors out to file - sometimes "empty" but extant colour dimensions can be present and mess things up. Also, fixed issue with how test data was set up.

* Make tests compile.

* Fixed test build error introduced by merge

* Move gltf writer configuration to ::prepared

u_short -> uint16_t

* revert whitespace changes

* add missing constructor

* create multiple gltf primitives instead of one

Co-authored-by: Andrew Bell <andrew.bell.ia at gmail.com>