[pdal] Compile error with master

[Andrew Bell]

On Fri, Apr 15, 2016 at 1:23 AM, Mateusz Loskot <mateusz at loskot.net> wrote:

> On 15 April 2016 at 08:11, Stefan Ziegler <stefan.ziegler.de at gmail.com>
> wrote:
> >
> > /home/stefan/sources/pdal/plugins/pcl/kernel/ViewKernel.cpp:139:54: note:
> > candidate is:
> > In file included from
> > /home/stefan/sources/pdal/plugins/pcl/kernel/ViewKernel.hpp:38:0,
> >                  from
> > /home/stefan/sources/pdal/plugins/pcl/kernel/ViewKernel.cpp:35:
> > /home/stefan/sources/pdal/include/pdal/Kernel.hpp:81:12: note:
> pdal::Stage&
> > pdal::Kernel::makeReader(const string&, std::string)
> >      Stage& makeReader(const std::string& inputFile, std::string driver);
> >             ^
> > /home/stefan/sources/pdal/include/pdal/Kernel.hpp:81:12: note:
>  candidate
> > expects 2 arguments, 1 provided
> > make[2]: ***
> >
> [plugins/pcl/CMakeFiles/pdal_plugin_kernel_view.dir/kernel/ViewKernel.cpp.o]
> > Error 1
> > make[1]: *** [plugins/pcl/CMakeFiles/pdal_plugin_kernel_view.dir/all]
> Error
> > 2
> > make: *** [all] Error 2
>
> It looks like PCL plugin is missing update related to this change
>
> https://github.com/PDAL/PDAL/commit/2b2eeba95906f5a96fab88d88fb0a0fae59397df
>
> Perhaps it will be enough to patch the
> pdal/plugins/pcl/kernel/ViewKernel.cpp:139
>
> Stage& readerStage(Kernel::makeReader(m_inputFile));
>
> to read
>
> Stage& readerStage(Kernel::makeReader("kernels.view", m_inputFile));
>

Brad told me nobody was using the PCL viewer.  I guess that's incorrect :)

The change should be to:

Stage& readerStage(Kernel::makeReader("m_inputFile, ""));

I'll make the change in master.

-- 
Andrew Bell
andrew.bell.ia at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/pdal/attachments/20160415/687c2910/attachment-0001.html>