[postgis-devel] STYLE

[Mark Cave-Ayland]

Paul Ramsey wrote:

> http://svn.refractions.net/postgis/trunk/STYLE
> 
> This is not meant to be the last word, it's just a draft, please add
> your changes as you see fit (you in particular, Mark).
> 
> On a related note, as I work with liblwgeom, I wish we had more API
> documentation than the header file... I think doxygen will work fine
> w/ C. should we commit to doxygen as our in-code standard?
> 
> P.

This looks entirely sensible, nice work Paul :)  I think at some point 
we should just add a script to the repo that will indent all the .c/.h 
files (excluding those used to generate .sql.in files) and run it as we 
hit RC. Doxygen is something I've not personally used, although I've 
used equivalents for PHP etc. Have you got any example files in trunk I 
could run it on to take a look?

BTW I noticed your r3450 commit, and this got me thinking. One of things 
that really trips me up at the moment is LWCURVE - why oh why was it not 
called LWCIRCSTRING??! This tends to trip me up a lot, since SQL-MM 
defines a curve as a LINESTRING or a CIRCULARSTRING and so makes the 
logic a lot harder to follow when trying to map SQL types to C types.

So would anyone really object if I performed another massively invasive 
substitution to get this out of my system for once and for all on trunk? 
I promise not to break the build ;)


ATB,

Mark.

-- 
Mark Cave-Ayland
Sirius Corporation - The Open Source Experts
http://www.siriusit.co.uk
T: +44 870 608 0063