[postgis-devel] Compilation using Visual C++ 8.0

[Mark Cave-Ayland]

Mateusz Loskot wrote:

> Mark, have you had a chance to test it?
> Anyone?

Hi Mateusz,

Yeah, I did take a look at this. I've just been involved in another 
couple of projects recently which have taken up most of my time, 
although things should clear up after another couple of weeks. So sorry 
for any apparent lack of interest.


Just some notes:

- The patches seem out of date, in that I've already removed unistd.h 
from several header files, but these are still included in your patches.

- The patch introduces several different new directories like 
platform/build without any real justification. Is this a standard 
MSVC-type project layout?

- The patch includes a postgis/postgis.def file - should this not be 
generated as part of the compilation process rather than included as a 
static file in SVN?

- The patch simply includes postgis.sql, rather than generating it from 
the C pre-processor. IMHO this one of the most important parts of the 
build system to get right for a given platform. How can this be emulated 
using MSVC?

- I don't see any evidence of building liblwgeom into a static library. 
This is needed because not only does the library link with 
postgis-1.4.dll, but also with the shapefile loaders. I think this is 
also a critical part of the build to get right.


Also I'd like to see evidence of a clean regression run from an MSVC 
build before committing some of this into the repository - just because 
it builds doesn't necessarily mean that it works ;)


HTH,

Mark.

-- 
Mark Cave-Ayland - Senior Technical Architect
PostgreSQL - PostGIS
Sirius Corporation plc - control through freedom
http://www.siriusit.co.uk
t: +44 870 608 0063