[postgis-devel] [PostGIS] #228: postgis_restore.pl createdb parameters are used also for createlang -> crash

[PostGIS]

#228: postgis_restore.pl createdb parameters are used also for createlang ->
crash
----------------------------------------------------------+-----------------
 Reporter:  havatv                                        |       Owner:  pramsey      
     Type:  defect                                        |      Status:  new          
 Priority:  medium                                        |   Milestone:  postgis 1.5.0
Component:  postgis                                       |     Version:  1.4          
 Keywords:  hard upgrade, postgis_restore.pl, parameters  |  
----------------------------------------------------------+-----------------
 I have installed 1.4.0, and wanted to test a hard upgrade using
 postgis_restore.pl, as described in the user manual
 (http://postgis.refractions.net/documentation/manual-1.4/ch02.html#hard_upgrade
 - 2.7.2 Hard upgrade).

 The user manual says that postgis_restore.pl can take parameters and pass
 them on to createdb.  This works fine.
 However, these parameters are also passed on to createlang, which is not
 happy with the createdb specific options and therefore aborts, so
 postgis_restore.pl is aborted as well.

 With the example used in the documentation ({{{sh utils/postgis_restore.pl
 postgis.sql newdb olddb.dump -E=UNICODE}}}), I get the following error
 message (Norwegian translation: "ugyldig flagg": invalid flag):

 {{{
     createlang: ugyldig flagg -- E
     Try "createlang --help" for more information.
 }}}

 Also:  It could perhaps be useful to include info on upgrade in the
 release notes, even if soft upgrade is recommended by default (there has
 not been any mention of upgrading in the release notes since 1.1.6).

-- 
Ticket URL: <http://trac.osgeo.org/postgis/ticket/228>
PostGIS <http://trac.osgeo.org/postgis/>
PostGIS