[postgis-devel] More dump comments

Mark Cave-Ayland mark.cave-ayland at siriusit.co.uk
Fri Feb 27 07:10:23 PST 2009


Obe, Regina wrote:

> I guess no one knows the answer to the below 2 questions
> 
> In LWGeom_dump and LWGEOM_dump_rings
> 
> We do this
> 
>                 /* allocate a slot for a tuple with this tupdesc */
>                 slot = TupleDescGetSlot(tupdesc);
> 
>                 /* allocate a slot for a tuple with this tupdesc */
>                 slot = TupleDescGetSlot(tupdesc);
> 
> Is there a reason for setting this twice?

I haven't looked at it in any detail, but it looks like a typo to me. If 
you remove one of them, does it pass both regression and the garden test 
in SVN trunk?

Assuming that everything still works after this, feel free to commit 
this to trunk.


ATB,

Mark.

-- 
Mark Cave-Ayland - Senior Technical Architect
PostgreSQL - PostGIS
Sirius Corporation plc - control through freedom
http://www.siriusit.co.uk
t: +44 870 608 0063



More information about the postgis-devel mailing list