[postgis-devel] More dump comments

[Obe, Regina]

Mark or Tom,

Okay I did this for 1.4 but have not done it for 1.3 yet.  We don't
support 8.0 in 1.3 either correct.

In inspecting the torture test, I noticed something strange with the
dump results that I don't think have anything to do with my changes.
though I'll have to revert back to be sure.

When dumping geometry collections -- it dumps out like this

                     ?column?                      
---------------------------------------------------
 ST_Dump GCSet3D: Start Testing GEOMETRYCOLLECTION
(1 row)

BEGIN
 
st_dump

------------------------------------------------------------------------
-----
 
("{1,1}",01010000A0E610000000000000000024C000000000000049400000000000000
040) 

But for MULTIPOLYGONs and single geom constructs, we don't have double
quotes.  Why do we have quotes here.  Is that even legal? (or is that
part of what Bless does)

Below is a sample of a multi

                      ?column?                       
-----------------------------------------------------
 ST_Dump MultiLineSet: Start Testing MULTILINESTRING
(1 row)

BEGIN
                                              st_dump

------------------------------------------------------------------------
-----------------------
 
({1},0102000020E61000000200000000000000000024C00000000000004440000000000
000444000000000000024C0)

-----Original Message-----
From: postgis-devel-bounces at postgis.refractions.net
[mailto:postgis-devel-bounces at postgis.refractions.net] On Behalf Of Mark
Cave-Ayland
Sent: Friday, February 27, 2009 10:10 AM
To: PostGIS Development Discussion
Subject: Re: [postgis-devel] More dump comments

Obe, Regina wrote:

> I guess no one knows the answer to the below 2 questions
> 
> In LWGeom_dump and LWGEOM_dump_rings
> 
> We do this
> 
>                 /* allocate a slot for a tuple with this tupdesc */
>                 slot = TupleDescGetSlot(tupdesc);
> 
>                 /* allocate a slot for a tuple with this tupdesc */
>                 slot = TupleDescGetSlot(tupdesc);
> 
> Is there a reason for setting this twice?

I haven't looked at it in any detail, but it looks like a typo to me. If

you remove one of them, does it pass both regression and the garden test

in SVN trunk?

Assuming that everything still works after this, feel free to commit 
this to trunk.


ATB,

Mark.

-- 
Mark Cave-Ayland - Senior Technical Architect
PostgreSQL - PostGIS
Sirius Corporation plc - control through freedom
http://www.siriusit.co.uk
t: +44 870 608 0063
_______________________________________________
postgis-devel mailing list
postgis-devel at postgis.refractions.net
http://postgis.refractions.net/mailman/listinfo/postgis-devel
-----------------------------------------
The substance of this message, including any attachments, may be
confidential, legally privileged and/or exempt from disclosure
pursuant to Massachusetts law. It is intended
solely for the addressee. If you received this in error, please
contact the sender and delete the material from any computer.