[postgis-devel] Naming Nit
Mark Cave-Ayland
mark.cave-ayland at siriusit.co.uk
Thu Jan 8 12:18:34 PST 2009
Paul Ramsey wrote:
> As I did the memory change this morning, I noticed I was changing
> lwfree_<type> to <type>_release. Given the layout of code in the
> <type>.c files, probably lwfree_<type> should be <type>_free.
>
> This is the kind of tidying which is useful but feels pointless, and
> potentially annoys people, hence the e-mail.
+1 from me - I've noticed this before but never got around to doing
anything about it.
> A second nit, we've got
>
> extern POINTARRAY *pointArray_construct(uchar *points, char hasz, char
> hasm, uint32 npoints);
> which lives in lwgeom_api.c
>
> and
>
> extern POINTARRAY *ptarray_construct(char hasz, char hasm, unsigned int
> npoints);
> which lives in ptarray.c
>
> w00t!
???!
ATB,
Mark.
--
Mark Cave-Ayland
Sirius Corporation - The Open Source Experts
http://www.siriusit.co.uk
T: +44 870 608 0063
More information about the postgis-devel
mailing list