[postgis-devel] shapelib fixes ?

[strk]

Salve Regina!

I noticed this commit:

* r3561 /trunk/loader/dbfopen.c: Fix DBFReadDeleted logic
  -- should return 1 if record is deleted and 0 if it is not
  deleted

Note that dbfopen.c is part of Frank Warmerdam's
shapelib, copied in postgis tree verbatim and occasionally
updated to new versions.
This means that on next update your "fix" would be reverted
(unless it is in upstream, which I strongly dubt).

Generally, returning 0 for success and 1 for error is a trick
to allow for fine-grained error reporting. A success is
a success, while an error can be for different reasons, thus
the non-zero return on error.

--strk;

 Free GIS & Flash consultant/developer      ()  ASCII Ribbon Campaign
 http://foo.keybit.net/~strk/services.html  /\  Keep it simple!