[postgis-devel] shapelib fixes ?

[Mark Cave-Ayland]

strk wrote:

> Note that dbfopen.c is part of Frank Warmerdam's
> shapelib, copied in postgis tree verbatim and occasionally
> updated to new versions.
> This means that on next update your "fix" would be reverted
> (unless it is in upstream, which I strongly dubt).
> 
> Generally, returning 0 for success and 1 for error is a trick
> to allow for fine-grained error reporting. A success is
> a success, while an error can be for different reasons, thus
> the non-zero return on error.

I'd say that Regina's fix is fine for 1.3 branch as we are trying to 
minimise changes there; however it may be worth importing again from 
upstream for SVN trunk.


ATB,

Mark.

-- 
Mark Cave-Ayland
Sirius Corporation - The Open Source Experts
http://www.siriusit.co.uk
T: +44 870 608 0063