[postgis-devel] loader/Makefile is broken in 1.4rc1

[Devrim GÜNDÜZ]

Hi,

loader/Makefile is broken AFAICS. It does not honor DESTDIR , as it used
to do in 1.3.6. Here is a diff between 1.3.6 Makefile and 1.4.0rc1 one:

 install: all
-	@mkdir -p $(DESTDIR)$(bindir)
-	$(INSTALL_BIN) pgsql2shp$(EXE) $(DESTDIR)$(bindir)/pgsql2shp$(EXE)
-	$(INSTALL_BIN) shp2pgsql$(EXE) $(DESTDIR)$(bindir)/shp2pgsql$(EXE)
+	@cp $(PGSQL2SHP) $(PGSQL_BINDIR)/$(PGSQL2SHP)
+	@cp $(SHP2PGSQL) $(PGSQL_BINDIR)/$(SHP2PGSQL)
 

which results in:

make[2]: Leaving directory `/home/devrim/rpm/BUILD/postgis-1.4.0rc1/postgis'
make -C loader install
make[2]: Entering directory `/home/devrim/rpm/BUILD/postgis-1.4.0rc1/loader'
cp: cannot create regular file `/usr/bin/pgsql2shp': Permission denied
make[2]: *** [install] Error 1
make[2]: Leaving directory `/home/devrim/rpm/BUILD/postgis-1.4.0rc1/loader'
make[1]: *** [loaderdumper-install] Error 2
make[1]: Leaving directory `/home/devrim/rpm/BUILD/postgis-1.4.0rc1'
error: Bad exit status from /var/tmp/rpm-tmp.MmIpx5 (%install)

See cp part -- it does not honor DESTDIR parameter.

Also, why are these hardcoded in the same Makefile?

# PostgreSQL frontend CPPFLAGS and LDFLAGS (for compiling and linking with libpq)
PGSQL_FE_CPPFLAGS=-I/usr/local/pgsql/8.3/include
PGSQL_FE_LDFLAGS=-L/usr/local/pgsql/8.3/lib -lpq

# PostgreSQL executable directory
PGSQL_BINDIR=/usr/local/pgsql/8.3/bin

Regards,


-- 
Devrim GÜNDÜZ, RHCE
Command Prompt - http://www.CommandPrompt.com 
devrim~gunduz.org, devrim~PostgreSQL.org, devrim.gunduz~linux.org.tr
                   http://www.gunduz.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osgeo.org/pipermail/postgis-devel/attachments/20090704/21966c9d/attachment.sig>