[postgis-devel] [PostGIS] #311: Rename postgis.sql to postgis-1.5.sql
PostGIS
trac at osgeo.org
Thu Jan 7 05:43:14 PST 2010
#311: Rename postgis.sql to postgis-1.5.sql
----------------------+-----------------------------------------------------
Reporter: pramsey | Owner: mcayland
Type: defect | Status: new
Priority: medium | Milestone: PostGIS 1.5.0
Component: postgis | Version: trunk
Resolution: | Keywords:
----------------------+-----------------------------------------------------
Comment (by mcayland):
Okay folks. Tom committed a revised version of my patch here:
http://archives.postgresql.org/pgsql-committers/2010-01/msg00025.php
And so please find attached the relevant hackery for PostgreSQL < 8.5 as
postgis-contrib-directory.patch. So it's a particularly ugly hack, but by
basing it upon the 8.5 patch and putting all the horrible nastiness in a
separate file, it's fairly easy to switch the logic based upon the
PostgreSQL version and remove it as soon as PostgreSQL 8.5 becomes our
minimum supported version.
The only slightly annoying part is that because we are overriding 3 of the
PGXS targets then we get the following warnings when compiling on
PostgreSQL < 8.5:
Makefile.pgxs:17: warning: overriding commands for target `install'
/home/pg83/rel-8.3.7/lib/postgresql/pgxs/src/makefiles/pgxs.mk:96:
warning: ignoring old commands for target `install'
Makefile.pgxs:60: warning: overriding commands for target `installdirs'
/home/pg83/rel-8.3.7/lib/postgresql/pgxs/src/makefiles/pgxs.mk:143:
warning: ignoring old commands for target `installdirs'
Makefile.pgxs:79: warning: overriding commands for target `uninstall'
These are, fortunately, harmless but I couldn't find a way of suppressing
them. I've tested this on PostgreSQL 8.3 and 8.5 and it works as expected
for me, so I'm putting it out here for the others to test.
--
Ticket URL: <http://trac.osgeo.org/postgis/ticket/311#comment:18>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.
More information about the postgis-devel
mailing list