[postgis-devel] astyle

[Paragon Corporation]

Mark,

I agree with Mateusz on this one.  I think we should change peoples
behavior.  If people get slapped on the wrist enough they will follow our
styles.  


My reasoning is as follows

1) The change Paul requested was small and since 2.0 will not be released
for another year and with our new policy this change would not make it in
for another year.  
He would have dormant code sitting in 1.5.1 or whatever which I find
terribly annoying and he couldn't put it in 1.5.0 because code is code
regardless of if it changes API.

2) The re-formatting as Mateusz says is a cosmetic thing.  A cosmetic thing
that changes MANY FILES and makes code look different even if it is not.
That's worse than changing code before a release.

When you change many files randomly you have a relatively high probability
of something going wrong and that wrongness is unpredictable.  That is why I
say it requires more testing for that.

Besides this is something that doesn't change the API so can be done any
time.  I fail to see the sense of urgency in this.

Thanks,
Regina  

-----Original Message-----
From: postgis-devel-bounces at postgis.refractions.net
[mailto:postgis-devel-bounces at postgis.refractions.net] On Behalf Of Mark
Cave-Ayland
Sent: Wednesday, January 27, 2010 7:47 AM
To: PostGIS Development Discussion
Subject: Re: [postgis-devel] astyle

Paragon Corporation wrote:

> I don't like reformatting just before a major release.  This is 
> something that should have been done before an RC was called.  That 
> just sounds prone to error to me without time for recheck.  Can we do this
after 1.5 goes?
> 
> -1

Er what? So you are happy to allow Paul to add new functions after an RC
just before release, but not to run a re-formatting pass which doesn't make
any changes to the code at the same time? I'm sorry, but your logic here
escapes me...


ATB,

Mark.

--
Mark Cave-Ayland - Senior Technical Architect PostgreSQL - PostGIS Sirius
Corporation plc - control through freedom http://www.siriusit.co.uk
t: +44 870 608 0063

Sirius Labs: http://www.siriusit.co.uk/labs
_______________________________________________
postgis-devel mailing list
postgis-devel at postgis.refractions.net
http://postgis.refractions.net/mailman/listinfo/postgis-devel


__________ Information from ESET NOD32 Antivirus, version of virus signature
database 4809 (20100127) __________

The message was checked by ESET NOD32 Antivirus.

http://www.eset.com