[postgis-devel] [PostGIS] #791: Topology: function GetEdgeByPoint($1, $2, $3)

[PostGIS]

#791: Topology: function GetEdgeByPoint($1,$2,$3)
-------------------------+--------------------------------------------------
 Reporter:  aperi2007    |       Owner:  strk         
     Type:  enhancement  |      Status:  new          
 Priority:  medium       |   Milestone:  PostGIS 2.0.0
Component:  topology     |     Version:  trunk        
 Keywords:               |  
-------------------------+--------------------------------------------------

Comment(by robe):

 Andrea,

 This looks good except that you made the mistake of picking up our bad
 habits and are using antiquated aliasing syntax.

 Can you revise:

 So instead of:

 topology.GetEdgeByPoint(varchar, geometry, float8)

 Do
 topology.GetEdgeByPoint(atopology varchar, apoint geometry, tol1 float8)

 and get rid of your alias stuff.

 I think Strk started changing some functions, but can't recall which ones
 now.


 Also can you change your "point" in the documentation to "apoint".
 Ideally the doc arg names should match the functions arg names (just in
 case people start doing that named parameter calling stuff). Since I've
 been guilty of breaking this rule, just because i don't like the names of
 some of the function arguments it feels cruel of me to force it on you.

 Strk you have any comments or issues with accepting his patches? -- I
 haven't inspected the function that closely.

-- 
Ticket URL: <http://trac.osgeo.org/postgis/ticket/791#comment:5>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.