[postgis-devel] [PostGIS] #651: [raster] ST_makeemptyraster inconsistent with documentation

[PostGIS]

#651: [raster] ST_makeemptyraster inconsistent with documentation
-----------------------------+----------------------------------------------
  Reporter:  etiennebr       |       Owner:  pracine      
      Type:  defect          |      Status:  reopened     
  Priority:  medium          |   Milestone:  PostGIS 2.0.0
 Component:  postgis raster  |     Version:  trunk        
Resolution:                  |    Keywords:               
-----------------------------+----------------------------------------------
Changes (by pracine):

  * status:  closed => reopened
  * resolution:  fixed =>


Comment:

 I reoppen the ticket as the documentation is still confusing.

 1-The ipx and ipy where replaced in rtpostgis.sql to better express their
 meaning: "ipx" to "upperleftx" and "ipy" to "upperlefty"

 2-The type of these parameter are float8

 3-The description of these parameters is wrong in the documentation. It
 should read something like:

 "Returns an empty raster (having no band) of given dimensions (width &
 height) and georeferenced in spatial (or world) coordinates with upper
 left x (upperleftx), upper left y (upperlefty), pixel size expressed as
 scalex, scaley, skewx, skewy and reference system (srid). The last version
 use a single parameter to specify the pixel size (pixelsize). In this case
 scalex and scaley are set to this parameter and skewx and skewy are set to
 0. If an existing raster is passed in, it returns a new raster with the
 same meta data settings (without the bands). If no srid is specified it
 defaults to -1, though this may change to 0 in future. After you create an
 empty raster you probably want to add bands to it and maybe edit it. Refer
 to ST_AddBand to define bands and ST_SetValue to set pixel values."

 This introduce two things to fix:

 1-The last version in the doc name the last parameter "pixelsize" when
 rtpostgis.sql names it scale. It should probably better to modify
 rtpostgis.sql to match the doc.

 2-This same last version is kind of useless right now as the scaley
 parameter should be negated in the function and is not. Rasters created
 using this function are upside down in most reference systems.

-- 
Ticket URL: <https://trac.osgeo.org/postgis/ticket/651#comment:5>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.