[postgis-devel] [PostGIS] #1023: btree equality broken for geometries w/out a cached bounding box (topology regress failures related to GSERIALIZED) (was: topology regress failures related to GSERIALIZED: copytopology and)

[PostGIS]

#1023: btree equality broken for geometries w/out a cached bounding box (topology
regress failures related to GSERIALIZED)
---------------------+------------------------------------------------------
 Reporter:  robe     |       Owner:  pramsey      
     Type:  defect   |      Status:  new          
 Priority:  high     |   Milestone:  PostGIS 2.0.0
Component:  postgis  |     Version:  trunk        
 Keywords:           |  
---------------------+------------------------------------------------------
Changes (by strk):

  * owner:  strk => pramsey
  * component:  topology => postgis


Comment:

 Found the problem:
 pglwgeom_getbox2d_p is expected to _compute_ the bounding box when no
 cached.
 In the non-gserialized flavor it does so (getbox2d_p in lwgeom_api.c)
 but in the gserialized flavor it doesn't (gserialized_get_box_p in
 g_serialized.c)

 The pglwgeom_getbox2d_p function is NOT documented to require computation,
 but I do know it (eh...).

 So:

  1. Document behavior
  2. Fix it for GSERIALIZED

 I'd like to hear from Paul about this first though, in case he has other
 clients relying on gserialized_get_gbox_p NOT computing a missing box.

 What I could do meanwhile is providing a regression test for this bug,
 which is _unrelated_ to topologies.

-- 
Ticket URL: <http://trac.osgeo.org/postgis/ticket/1023#comment:7>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.