[postgis-devel] [PostGIS] #1097: postgis upgrade scripts not outputting geometry_columns

[PostGIS]

#1097: postgis upgrade scripts not outputting geometry_columns
----------------------+-----------------------------------------------------
 Reporter:  robe      |       Owner:  robe         
     Type:  defect    |      Status:  new          
 Priority:  critical  |   Milestone:  PostGIS 2.0.0
Component:  postgis   |     Version:  trunk        
 Keywords:            |  
----------------------+-----------------------------------------------------

Comment(by robe):

 Okay I give up on this one.  Can one of you perl geeks take acare of this.
 I assume it's jsut the postgis_proc_upgrade.pl that needs to be changed.
 I tried adding geometry_columns to the top and tried to get rid of the
 conditional check on version in create or replace view.  All that happened
 is my regress managed to break and was generating a postgis.sql that
 didn't have the regress postgis.lib (was pointing at my produciton).  Not
 sure how those 2 are connected.

 Anyrate:

 1) There is no reason WHAT SO EVER I can think of to not run

 CREATE OR REPLACE VIEW even on a minor upgrade, because as long as the
 column names and types don't change, then even dependent objects will be
 unaffected.

 on a minor upgrade

 2) Fro a major upgrade we might have to do a drop REPLACE, but lets just
 assume for simplicity we will never change the outter exterior (types of
 columns, column names) except possibly to add columns at the end.  Adding
 columns at the end is doable with a CREATE OR REPLACe


 so short -- we should always do a CREATE OR REPLACE VIEW for both minor
 and major

-- 
Ticket URL: <http://trac.osgeo.org/postgis/ticket/1097#comment:1>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.