[postgis-devel] Commit gudelines agreement (was: Speaking ofopenness and formality ...)

[Nicklas Avén]

I have one question about the commit guidlines agreement.

As Regina commented in #940 earlier today:
https://trac.osgeo.org/postgis/ticket/940#comment:19

there is a lot of code that astyle has not been used on.

The problem with astyle is that the output changes in different versions
as we have discussed some time earlier.

In my Ubuntu Maverick the version in the respositories is 1.24.

So, using astyle from repositories will mess up our code. 

I ask this sometimes before but I don't think I had an answer.
Wouldn't it be possible to run astyle on the svn-server instead?

We run a lot of different jobs building documentation, building postgis
for regresstest and so on.

Why is it a problem to run astyle somewhere in the chain too?

I think that would be great and then we could remove that line from the
committing guideline.

Aside from that I agree with everything in the guidelines and will of
course try to follow it.

Thanks
Nicklas


On Fri, 2011-05-13 at 04:22 -0400, Paragon Corporation wrote:
> I also agree with the guidelines as of version  1.00000006 and will to the
> best of my limited abilities, follow these guidelines.
> 
> Regina
> 
> -----Original Message-----
> From: postgis-devel-bounces at postgis.refractions.net
> [mailto:postgis-devel-bounces at postgis.refractions.net] On Behalf Of Sandro
> Santilli
> Sent: Friday, May 13, 2011 2:56 AM
> To: PostGIS Development Discussion
> Subject: [postgis-devel] Commit gudelines agreement (was: Speaking
> ofopenness and formality ...)
> 
> On Thu, May 12, 2011 at 09:14:53PM -0400, Paragon Corporation wrote:
> 
> > So one last formality remains before we can give Bborie commit rights 
> > - which actually all current committers have to retroactively agree to.
> > 
> > Can all folks listed on the bottom of this: 
> > http://trac.osgeo.org/postgis/wiki/DevWikiComitGuidelines
> > 
> > Including Bborie -- confirm they agree with these guidelines?
> 
> I agree with the guidelines as of version 1.00000006.
> 
> --strk;
> 
>   ()   Free GIS & Flash consultant/developer
>   /\   http://strk.keybit.net/services.html
> _______________________________________________
> postgis-devel mailing list
> postgis-devel at postgis.refractions.net
> http://postgis.refractions.net/mailman/listinfo/postgis-devel
> 
> 
> _______________________________________________
> postgis-devel mailing list
> postgis-devel at postgis.refractions.net
> http://postgis.refractions.net/mailman/listinfo/postgis-devel
>