[postgis-devel] [PostGIS] #1598: Use consistent UNIX line endings

PostGIS trac at osgeo.org
Wed Feb 22 04:52:00 PST 2012


#1598: Use consistent UNIX line endings
------------------------+---------------------------------------------------
 Reporter:  mwtoews     |       Owner:  chodgson     
     Type:  defect      |      Status:  new          
 Priority:  medium      |   Milestone:  PostGIS 2.0.0
Component:  management  |     Version:  trunk        
 Keywords:              |  
------------------------+---------------------------------------------------
 According to DevWikiComitGuidelines:
 > All source code in SVN should be in Unix text format as opposed to DOS
 text mode

 I've found a significant list of DOS files in the SVN tree. This can be
 slightly problematic; take a look at "invalid_srid-2.0.patch" in #1596,
 which was a patch created on a UNIX system from a DOS file. The resulting
 patch file has mixed line endings, which can cause grief for the patch
 utility.

 Examples of DOS files:
 {{{
 trunk/postgis/postgis.sql.in.c
 trunk/liblwgeom/measures3d.c
 ...
 }}}

 Of course, BAT files should probably be left alone:
 {{{
 trunk/extras/tiger_geocoder/tiger_2010/create_geocode.bat
 trunk/extras/tiger_geocoder/tiger_2010/upgrade_geocoder.bat
 }}}

 Another type of line ending error (according to some) are text files
 without a newline character at the end. These files lack consistency, and
 appear truncated. Possible consequences include a gcc warning: "No newline
 at end of file".

 Examples of files without newlines at the end:
 {{{
 trunk/LICENSE.TXT
 trunk/doc/faq.xml
 trunk/doc/html/image_src/de9im06.wkt
 trunk/liblwgeom/lwgeodetic.c
 ...
 }}}

 Possible exceptions are one-line text files, like Esri's .prj file (but
 there's none in the source tree).

-- 
Ticket URL: <http://trac.osgeo.org/postgis/ticket/1598>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.


More information about the postgis-devel mailing list