[postgis-devel] Rename a variable named errmsg in long_xact.c

[Sandro Santilli]

On Mon, May 04, 2015 at 05:52:53PM +1000, Haribabu Kommi wrote:
> On Mon, May 4, 2015 at 5:41 PM, Sandro Santilli <strk at keybit.net> wrote:
>
> > I see no problem with changing a variable name, but... are you saying
> > that PostgreSQL headers themselves are exposing a global "errmsg"
> > variable ? Or is your code doing that ?
> 
> Yes, In our forked PostgreSQL code, we changed the elog macro that is
> exposed in PostgreSQL headers to use the new ereport macro for better
> logging as follows.
> 
> #define elog(errorlevel, ...) ereport(errorlevel, (errmsg(__VA_ARGS__)))
> 
> This is causing us the problem.

Answering myself, this is also in the _original_ PostgreSQL (9.3) headers:

 include/server/utils/elog.h:147:errmsg(const char *fmt,...)

Patch applied and committed as r13472. Thank you.

--strk; 

  ()   Free GIS & Flash consultant/developer
  /\   http://strk.keybit.net/services.html