[postgis-devel] 2.2.0 passes regression tests on NetBSD 6 i386, perl path issue

[Greg Troxel]

I updated the pkgsrc package from 2.1.7 to 2.2.0 and it passes
regression tests (pgsql 9.3.9, geos 3.5.0, proj 4.9.2).

Should I be foisting this on the pkgsrc-using world, or waiting until
2.2.1?  It doesn't feel urgent if that's coming within weeks.

One of the things I notice in packaging is changes in the set of
installed files.   That's not a bug of course, but a chance to see if
the changes are entirely intended.

Extracts from a diff -u, with all the noise removed:

  +include/liblwgeom_topo.h
  +lib/postgresql/postgis_topology-2.2.so

  -share/postgresql/contrib/postgis-2.1/topology.sql
  -share/postgresql/contrib/postgis-2.1/topology_upgrade_21_minor.sql
  -share/postgresql/contrib/postgis-2.1/uninstall_sfcgal.sql
  -share/postgresql/contrib/postgis-2.1/uninstall_topology.sql

  +share/postgresql/contrib/postgis_topology-2.2/topology.sql
  +share/postgresql/contrib/postgis_topology-2.2/topology_upgrade.sql
  +share/postgresql/contrib/postgis_topology-2.2/uninstall_topology.sql

So there's a new header, and a new library - looks intended.

topology stuff in contrib is in a new subdir, compard to before, but the
comments file didn't move down.  That looks not clearly intended.


The other issue I ran into is an artifact of how pkgsrc packages
postgresql; the plperl module is built separately and the main build is
done without perl.  That is arguably wrong, but it results in pgxs
without PERL defined (or defined as missing).  (Really there should be
some way to have the main build *not* build plperl, but to search for
perl and put it in pgxs.mk, but that may be harder than it's worth.)

This surfaced the fact that how perl is used within postgis is somewhat
inconsistent.  It looks for perl and thus can substitute @PERL@ (normal
autoconf), and makefiles often have PERL=@PERL at .  However, they also
includes pgxs which sets PERL, and many but not all take pains to set
PERL=@PERL@ after pgxs.  Two did not, which caused the build to fail.
The following patches resolved the issue changing $(PERL) to @PERL at .

Now I know this is bogus, because my pgxs w/o perl is wrong.  But the
question is: is postgis going to look for perl with configure, or use
the pgxs path?  It seems like it should be one or the other, especially
if they could be different.  I vote for not using the pgxs perl path at
all, either by using @PERL@ instead of $(PERL) in makefiles, or my
uniformly including pgxs first and then setting variables.

--- extensions/postgis/Makefile.in.orig	2014-06-27 07:35:32.000000000 +0000
+++ extensions/postgis/Makefile.in
@@ -48,7 +48,7 @@ sql/$(EXTENSION)--$(EXTVERSION).sql: sql
 
 sql/$(EXTENSION)--unpackaged--$(EXTVERSION).sql: ../../postgis/postgis.sql ../../raster/rt_pg/rtpostgis.sql ../../utils/create_unpackaged.pl
 	mkdir -p sql
-	cat ../../postgis/postgis.sql ../../raster/rt_pg/rtpostgis.sql | $(PERL) ../../utils/create_unpackaged.pl postgis > $@
+	cat ../../postgis/postgis.sql ../../raster/rt_pg/rtpostgis.sql | @PERL@ ../../utils/create_unpackaged.pl postgis > $@
 	
 #this is a cludge to allow upgrading from same SVN to same SVN
 sql/$(EXTENSION)--$(EXTVERSION)--$(EXTVERSION)next.sql: sql_bits/postgis_raster_upgrade_minor.sql

--- extensions/postgis_topology/Makefile.in.orig	2014-06-27 07:35:32.000000000 +0000
+++ extensions/postgis_topology/Makefile.in
@@ -60,7 +60,7 @@ sql_bits/topology_comments.sql: ../../do
 	
 sql/$(EXTENSION)--unpackaged--$(EXTVERSION).sql: ../../topology/topology.sql ../../utils/create_unpackaged.pl
 	mkdir -p sql
-	cat $< | $(PERL) ../../utils/create_unpackaged.pl postgis_topology > $@
+	cat $< | @PERL@ ../../utils/create_unpackaged.pl postgis_topology > $@
 
 #upgrade script should have everything but table, schema, type creation/alter
 #NOTE: we assume all object definitions end in ;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 180 bytes
Desc: not available
URL: <http://lists.osgeo.org/pipermail/postgis-devel/attachments/20151009/4e4b90ae/attachment.sig>