[postgis-devel] extras/tiger_geocoder/upgrade_geocoder.bat and CRLF

[Regina Obe]

Hmm it seems our editorconfig doesn't have a rule for batch files.  I guess we should add one to force it to CRLF.

Though given I haven't touched those files in a while and my local is CRLF.  I'm not sure if that's the issue.

Anyrate does anyone see an issue with adding a rule to .editorconfig

[*.{bat}]
end_of_line = crlf


-----Original Message-----
From: postgis-devel [mailto:postgis-devel-bounces at lists.osgeo.org] On Behalf Of Mateusz Loskot
Sent: Monday, August 07, 2017 3:04 PM
To: PostGIS Development Discussion <postgis-devel at lists.osgeo.org>
Subject: Re: [postgis-devel] extras/tiger_geocoder/upgrade_geocoder.bat and CRLF

On 7 August 2017 at 20:47, Sandro Santilli <strk at kbt.io> wrote:
> On Mon, Aug 07, 2017 at 02:31:34PM -0400, Regina Obe wrote:
>>
>> We have in place svnprop that forces these files to have CRLF.
>
> Evidently it is not working, because what you committed does not have 
> the carriage returns.

Because Regina uses EditorConfig-aware editor whereas your .editorconfig forces .bat files to LF?

# these are the defaults
[*]
charset = utf-8
end_of_line = lf
trim_trailing_whitespace = true
insert_final_newline = true


Best regards,
--
Mateusz Loskot, http://mateusz.loskot.net _______________________________________________
postgis-devel mailing list
postgis-devel at lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/postgis-devel