[postgis-devel] Duplicate tags appearing in postgis git repo

[Sandro Santilli]

On Fri, May 19, 2017 at 10:17:38AM -0400, John Harvey wrote:
> Hi strk,
> 
> Thanks for the fix!  It is definitely cleaner now (I can confirm that the
> quote marks are gone).
> 
> Unfortunately, I've found a secondary issue.
> Some tags have now moved with the new method of tagging.

[...]

> If I were to make a guess, it appears that the new tagging method applies
> tags on the latest commit of certain branches (at least that's how it
> appears while looking at the git-tree).  However, such an algorithm would
> not take into account the case where tags were applied but yet further
> commits occurred along those branches after-the-fact.  I haven't seen the
> code, though-- this is just a guess from looking at the tree itself.
> 
> I'm guessing that this might be an issue.

The tagging method can be seen on the now public repository:
https://git.osgeo.org/gogs/postgis/repository-sync-scripts/src/master/git-svn-sync.sh#L26

I'm afraid SVN doesn't have a way to publish immutable tags, so
if a "tag branch" was committed into after-the-fact, we'd have no
way to know when the tag was made. Am I right in that reguard ?

The init script reconstructs the mirror from a git repository, but the
original git repository is now lost due to force-pushing new tag
values.  Some local ones may still exist, as yours and mine somewhere.
Do we really want to reconstruct those tags from our local values of
tags ? Note that only recently I added a -f to the `git tag` call in
that syncer, so it could very well be that the previous tag just
pointed to whatever state the SVN "tag/branch" had at time of
mirroring...

--strk;