[postgis-devel] Why delegating MakeValid to GEOS ?

Paul Ramsey pramsey at cleverelephant.ca
Thu Dec 10 12:48:08 PST 2020



> On Dec 10, 2020, at 12:41 PM, Sandro Santilli <strk at kbt.io> wrote:
> 
> Is there a good reason to delegate ST_MakeValid
> to GEOSMakeValid, when available ?

So that we eventually end up with all the behaviour in the same place?

> I'm asking because while changing ST_MakeValid to
> handle NaN I find myself having to do the same changes
> both in PostGIS and GEOS for people running older GEOS.

If you don't then we instead end up at a place where swapping implementations results in sudden behaviour change, which is Also Bad.

> How about keeping it all in PostGIS always until we drop
> support for older GEOS versions ?

Minimize the long term Badness by doing the Extra Work this problem requires.

P



More information about the postgis-devel mailing list