[postgis-devel] ST_Boundary refactoring: who's in charge ?

[Sandro Santilli]

For the record, I found the origin of the change being a github pull
request, and I've added a note using git-notes to the repository
to have it on the record for the future. Gitea shows commit notes, see:

  https://git.osgeo.org/gitea/postgis/postgis/commit/acd8f4ae2

Unfortunately not even github is able to tell who pushed the commit,
as the only visible "merger" is me, but only because the mirroring
bot runs in my name... I guess the actual merger was Darafei, as he
seems to be the only partecipant in the PR discussion.

I'm adding Darafei and the author of the commit in Cc.
Kalenik: are you willing to fix these issues ?

--strk;

On Thu, Jul 29, 2021 at 10:22:17PM +0200, Sandro Santilli wrote:
> It's disapponting to not find in git history how's in charge
> of accepting some contributions. I'm looking at commit 
> acd8f4ae2830a08b33f5b97d5f1ece073eb528f1 which has as the
> only information:
> 
>     commit acd8f4ae2830a08b33f5b97d5f1ece073eb528f1
>     Author: kalenikaliaksandr <kalenik.aliaksandr at gmail.com>
>     Date:   Sun Apr 4 17:45:08 2021 +0300
> 
>         ST_Boundary refactoring
> 
> No ticket reference, no reference about who pushed such commit
> to the repository.
> 
> The problem is that the above refactoring broke a few things.
> I filed a couple (#4956, #4960) but there are more I didn't file yet, ie:
> 
>   SELECT ST_Boundary('MULTIPOLYGON(((0 0, 5 5, 10 0, 0 0),(3 1,7 1,5 2,3 1)),((20 0,20 5,25 5,20 0)))');
> 
> I've started some work with a unit testing for the function:
> 
>   https://gitlab.com/postgis/postgis/-/merge_requests/50
> 
> But I'm finding so many issues that I'd like to stop here and call
> whoever is in charge for that change to fix the issue or revert it,
> can you help finding who's responsible for that change ?
> 
> In general, should we set a policy about *enforcing* a reference to
> external history about who's in charge for accepting changes ?
> Maybe using --signoff switch to git commit ?
> 
> --strk; 
> 
>   ()   Free GIS & Flash consultant/developer
>   /\   https://strk.kbt.io/services.html