[postgis-tickets] [PostGIS] #2307: ST_MakeValid outputs invalid geometries

[PostGIS]

#2307: ST_MakeValid outputs invalid geometries
-----------------------+----------------------------------------------------
  Reporter:  dmiranda  |       Owner:  pramsey      
      Type:  defect    |      Status:  reopened     
  Priority:  high      |   Milestone:  PostGIS 2.0.4
 Component:  postgis   |     Version:  2.0.x        
Resolution:            |    Keywords:  st_makevalid 
-----------------------+----------------------------------------------------
Changes (by strk):

  * status:  closed => reopened
  * resolution:  fixed =>


Comment:

 Thanks, but test in r11620 is only at the PostgreSQL level, where memory
 management is performed with leak-free palloc system. My concern is at
 liblwgeom level, where NOT freeing might result in a leak, doesn't it ?

 As far as I can tell, the lwgeom_as_multi function always creates new
 memory, not wrapping the input, check out
 http://trac.osgeo.org/postgis/browser/tags/2.1.0beta3/liblwgeom/lwgeom.c#L284

 Maybe there's a bug in lwgeom_clone, used when the input to
 lwgeom_as_multi is a collection ?

 Please add the test to cunit/cu_clean.c so we can more easily put under
 valgrind.

-- 
Ticket URL: <http://trac.osgeo.org/postgis/ticket/2307#comment:6>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.