[postgis-tickets] [PostGIS] #2254: Add SFCGAL support
PostGIS
trac at osgeo.org
Sun May 5 09:05:33 PDT 2013
#2254: Add SFCGAL support
--------------------------+-------------------------------------------------
Reporter: colivier | Owner: colivier
Type: enhancement | Status: new
Priority: medium | Milestone: PostGIS 2.1.0
Component: postgis | Version: trunk
Keywords: CGAL, SFCGAL |
--------------------------+-------------------------------------------------
Comment(by robe):
Olivier,
Sorry I should have looked closely at the patch. I see 2 main issues
1) Your SQL functions can't be folded into postgis.sql, they have to be in
a separate file similar to what is done for topology and tiger geocoder.
This is for 2 reasons mostly because of the way extensions work
a) functions in an extension can't be different based on whether or not
you compile with something.
b) sfcgal function are in a separate schema and all functions in an
extension NEED TO BE in same schema.
c) You need to be able to install sfcgal as an extension for it to make
the 9.1+ cut. If you need help with this, I can help out. That means you
will need a folder in /extensions folder similar to what is done with
postgis, postgis_topology, postgis_tiger_geocoder
That said please make these changes before committing (might be better for
you to just attach another patch and I'll inspect to see if I see any
glaring issues). If you can't we really need to push this to 2.2.
--
Ticket URL: <http://trac.osgeo.org/postgis/ticket/2254#comment:6>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.
More information about the postgis-tickets
mailing list