[postgis-tickets] [PostGIS] #2303: shp2pgsql-gui double includes postgis_config.h and parts of liblwgeom

[PostGIS]

#2303: shp2pgsql-gui double includes postgis_config.h and parts of liblwgeom
---------------------------+------------------------------------------------
 Reporter:  robe           |       Owner:  mcayland     
     Type:  defect         |      Status:  new          
 Priority:  medium         |   Milestone:  PostGIS 2.0.4
Component:  loader/dumper  |     Version:  trunk        
 Keywords:                 |  
---------------------------+------------------------------------------------
 In trying to troubleshoot why I always have random problems with
 shp2pgsql-gui and not with the commandline one.  I noticed it has double
 includes (or at least I think it does).

 It has an include at top for ../postgis_config.h

 Then it includes shp2pgsql-core.h  and  pgsql2shp-core.h of which
 shp2pgsql-core.h also includes postgis_config.h

 I'm also wondering why we need liblwgeom.h (when note says for
 lw_vasprintf).

 When shp2pgsql-core.h already explicitly includes


 {{{
 #include "../liblwgeom/stringbuffer.h"
 }}}

 which contains the vasprintf thingy.

-- 
Ticket URL: <http://trac.osgeo.org/postgis/ticket/2303>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.