[postgis-tickets] [PostGIS] #2335: rename internal LWGEOMWKB to be a bit more clear it is for EWKB

PostGIS trac at osgeo.org
Thu May 16 22:52:59 PDT 2013


#2335: rename internal LWGEOMWKB to be a bit more clear it is for EWKB
---------------------+------------------------------------------------------
 Reporter:  robe     |       Owner:  pramsey      
     Type:  defect   |      Status:  new          
 Priority:  medium   |   Milestone:  PostGIS 2.1.0
Component:  postgis  |     Version:  trunk        
 Keywords:           |  
---------------------+------------------------------------------------------
 I normally don't get offended by naming conventions, but this one is
 really offending my sense of etiquette.

 As noted in #2332

 We have two internal functions: LWGEOMFromWKB  (which is used for ewkb
 conversion) -
 http://postgis.net/docs/doxygen/2.1/d9/d6e/lwgeom__inout_8c_source.html#l00330

  and LWGEOM_from_WKB (
 http://postgis.net/docs/doxygen/2.1/da/d94/lwgeom__ogc_8c_source.html#l00790
 )(which is used for plain WKB conversion).  From the anming its really
 hard to know thier is a difference.  If we can't consolidate these, can we
 at least call LWGEOMFromWKB LWGEOMFromeWKB or something so its clearer its
 purpose?

-- 
Ticket URL: <http://trac.osgeo.org/postgis/ticket/2335>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.


More information about the postgis-tickets mailing list