[postgis-tickets] [PostGIS] #2185: Geometry output functions crash server with invalid WKT

[PostGIS]

#2185: Geometry output functions crash server with invalid WKT
------------------------+---------------------------------------------------
 Reporter:  mwtoews     |       Owner:  pramsey      
     Type:  defect      |      Status:  new          
 Priority:  blocker     |   Milestone:  PostGIS 2.0.4
Component:  postgis     |     Version:  2.0.x        
 Keywords:  windows 64  |  
------------------------+---------------------------------------------------

Comment(by robe):

 Actually I think the trick is the PG_RETURN_NULL.  I can prevent the leak
 by changing that line to a


 {{{
  if ( lwgeom_parse_wkt(&lwg_parser_result, str, LW_PARSER_CHECK_ALL) ==
 LW_FAILURE )
     {
          PG_PARSER_ERROR(lwg_parser_result);
          PG_RETURN_NULL();
       }
 }}}

 Though I had assumed the PG_PARSER_ERROR would exit the function so
 surprised that makes a difference.  You see an issue with just returning
 PG_RETURN_NULL() in these cases?

-- 
Ticket URL: <http://trac.osgeo.org/postgis/ticket/2185#comment:33>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.