[postgis-tickets] [PostGIS] #2872: make install builds documentation
PostGIS
trac at osgeo.org
Tue Aug 26 17:40:59 PDT 2014
#2872: make install builds documentation
-----------------------------------+----------------------------------------
Reporter: gdt | Owner: strk
Type: defect | Status: new
Priority: medium | Milestone: PostGIS 2.1.4
Component: build/upgrade/install | Version: 2.1.x
Keywords: |
-----------------------------------+----------------------------------------
Comment(by gdt):
(Sorry for the delay.) I applied the patch, and did build/install with
and without the patch. The patch didn't seem to cause any problems, and
it fixed a lot of the build activity at install time problems. So I'd say
yes, please backport to 2.1.
I do see some remaining issues, basically the 2 for loops to create
upgrade files for various versions. The code does get run during build,
but is rerun at install time, as shown by "make install" output and also
new timestamps in the source tree.
{{{
for OLD_VERSION in 2.0.0 2.0.1 2.0.2 2.0.3 2.0.4 2.0.5; do \
cat sql_bits/extension_upgrade_minor.sql >
sql/postgis--$OLD_VERSION--2.1.3.sql; \
done
for OLD_VERSION in 2.1.0rc1 2.1.0rc2 2.1.0rc3 2.1.0 2.1.1 2.1.2; do \
cat sql_bits/extension_upgrade_patch.sql >
sql/postgis--$OLD_VERSION--2.1.3.sql; \
done
}}}
I can't immediately explain, but it looks like the make rule always fires
and then runs a for loop, without some sort of "touch upgrade-
multiversion-done" canary. Either that or explicit rules per version, but
that sounds really awkward.
--
Ticket URL: <http://trac.osgeo.org/postgis/ticket/2872#comment:15>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.
More information about the postgis-tickets
mailing list