[postgis-tickets] [PostGIS] #3224: wrong test condition in lwt_AddIsoEdge()

[PostGIS]

#3224: wrong test condition in lwt_AddIsoEdge()
-----------------------+---------------------------
 Reporter:  esseffe    |      Owner:  pramsey
     Type:  defect     |     Status:  new
 Priority:  high       |  Milestone:  PostGIS 2.2.0
Component:  liblwgeom  |    Version:  2.1.x
 Keywords:             |
-----------------------+---------------------------
 I noticed a trivial typo within the lwt_AddIsoEdge() code causing logical
 inversion in a rather critical test.
 the following patch seems to resolve any issue:

 lwgeom_topo.c - line 720
 {{{
   const LWT_ISO_NODE *n = &(endpoints[i]);
 - if ( n->containing_face == -1 )
 + if ( n->containing_face != -1 )
   {
      _lwt_release_nodes(endpoints, num_nodes);
      lwerror("SQL/MM Spatial exception - not isolated node");
      return -1;
   }
 }}}

--
Ticket URL: <https://trac.osgeo.org/postgis/ticket/3224>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.