[postgis-tickets] r15397 - Revise the PGVERSION numbering scheme so also works for PostgreSQL 10beta1 and for all future PostgreSQL after 10

Regina Obe lr at pcorp.us
Sat May 20 10:49:52 PDT 2017


Author: robe
Date: 2017-05-20 10:49:52 -0700 (Sat, 20 May 2017)
New Revision: 15397

Modified:
   trunk/configure.ac
Log:
Revise the PGVERSION numbering scheme so also works for PostgreSQL 10beta1 and for all future PostgreSQL after 10
Note previous patch put in did not consider the case of when 10.11 comes, that would end up ranking higher than 11.0 (110 vs. 1011).  
So we need to totally disregard the minor version for PostgreSQL  >= 10
Closes #3614

Modified: trunk/configure.ac
===================================================================
--- trunk/configure.ac	2017-05-19 01:59:22 UTC (rev 15396)
+++ trunk/configure.ac	2017-05-20 17:49:52 UTC (rev 15397)
@@ -436,9 +436,18 @@
   dnl Note: we extract the major & minor separately, ensure they are numeric, and then combine to give
   dnl the final version. This is to guard against user error...
   PGSQL_FULL_VERSION=`"$PG_CONFIG" --version`
+
   PGSQL_MAJOR_VERSION=`echo $PGSQL_FULL_VERSION | sed 's/[[^0-9]]*\([[0-9]]*\).*/\1/'`
-  PGSQL_MINOR_VERSION=`echo $PGSQL_FULL_VERSION | sed 's/[[^\.]]*\.\([[0-9]]*\).*/\1/'`
-  PGSQL_MINOR_VERSION=`echo $PGSQL_MINOR_VERSION | sed 's/.*devel.*/0/'`
+  PGSQL_MINOR_VERSION=`$PG_CONFIG --version | sed 's/[[^0-9]]*\([[0-9]]\)\.\([[0-9]]\).*/\2/'`
+  
+  if test $PGSQL_MAJOR_VERSION -gt 9; then
+  	dnl ================================================================== 
+  	dnl Starting with PostgreSQL 10, major is the new minor
+  	dnl This is to prevent things like 10.31 ranking higher than 11.0
+  	dnl===================================================================
+  	PGSQL_MINOR_VERSION=0
+  fi
+
   POSTGIS_PGSQL_VERSION="$PGSQL_MAJOR_VERSION$PGSQL_MINOR_VERSION"
 
   PGSQL_PKGLIBDIR=`"$PG_CONFIG" --pkglibdir`



More information about the postgis-tickets mailing list