[postgis-tickets] [PostGIS] #3758: PostgreSQL 10 beta1 fails compile in gserialized_estimate

[PostGIS]

#3758: PostgreSQL 10 beta1 fails compile in gserialized_estimate
----------------------+---------------------------
  Reporter:  robe     |      Owner:  pramsey
      Type:  defect   |     Status:  new
  Priority:  blocker  |  Milestone:  PostGIS 2.4.0
 Component:  postgis  |    Version:  trunk
Resolution:           |   Keywords:
----------------------+---------------------------

Comment (by robe):

 After I made the change in r15398, it compiles and now get same as before:


 {{{
 PostgreSQL 10beta1 on x86_64-w64-mingw32, compiled by gcc.exe
 (x86_64-win32-seh-rev4, Built by MinGW-W64 project) 4.9.2, 64-bit
   Postgis 2.4.0dev - r15397 - 2017-05-21 03:07:57
   scripts 2.4.0dev r15397
   GEOS: 3.7.0dev-CAPI-1.11.0 8fe2ce6
   PROJ: Rel. 4.9.1, 04 March 2015
   SFCGAL: 1.3.0

 Running tests

  loader/Point .............. ok
  loader/PointM .............. ok
  loader/PointZ .............. ok
  loader/MultiPoint .............. ok
  loader/MultiPointM .............. ok
  loader/MultiPointZ .............. ok
  loader/Arc .............. ok
  loader/ArcM .............. ok
  loader/ArcZ .............. ok
  loader/Polygon .............. ok
  loader/PolygonM .............. ok
  loader/PolygonZ .............. ok
  loader/TSTPolygon ......... ok
  loader/TSIPolygon ......... ok
  loader/TSTIPolygon ......... ok
  loader/PointWithSchema ..... ok
  loader/NoTransPoint ......... ok
  loader/NotReallyMultiPoint ......... ok
  loader/MultiToSinglePoint ......... ok
  loader/ReprojectPts ........ ok
  loader/ReprojectPtsGeog ........ ok
  loader/Latin1 .... ok
  loader/Latin1-implicit .... ok
  loader/mfile .... ok
  dumper/literalsrid ....... ok
  dumper/realtable ....... ok
  affine .. ok
  bestsrid .. ok
  binary .. ok
  boundary .. ok
  cluster .. ok
  concave_hull .. ok
  ctors .. ok
  dump .. ok
  dumppoints .. ok
  empty .. ok
  estimatedextent .. ok
  forcecurve .. ok
  geography .. ok
  geometric_median .. ok
  in_geohash .. ok
  in_gml .. ok
  in_kml .. ok
  in_encodedpolyline .. ok
  iscollection .. ok
  legacy .. ok
  long_xact .. ok
  lwgeom_regress .. ok
  measures .. ok
  minimum_bounding_circle .. ok
  normalize .. ok
  operators .. ok
  orientation .. ok
  out_geometry .. ok
  out_geography .. ok
  polygonize .. ok
  polyhedralsurface .. ok
  postgis_type_name .. ok
  regress .. ok
  regress_bdpoly .. ok
  regress_index .. ok
  regress_index_nulls .. ok
  regress_management .. ok
  regress_selectivity .. failed (diff expected obtained:
 /projects/postgis/tmp/2.4_pg10w64/test_64_diff)
  regress_lrs .. ok
  regress_ogc .. ok
  regress_ogc_cover .. ok
  regress_ogc_prep .. ok
  regress_proj .. ok
  relate .. ok
  remove_repeated_points .. ok
  removepoint .. ok
  setpoint .. ok
  simplify .. ok
  simplifyvw .. ok
  size .. ok
  snaptogrid .. ok
  split .. ok
  sql-mm-serialize .. ok
  sql-mm-circularstring .. ok
  sql-mm-compoundcurve .. ok
  sql-mm-curvepoly .. ok
  sql-mm-general .. ok
  sql-mm-multicurve .. ok
  sql-mm-multisurface .. ok
  swapordinates .. ok
  summary .. ok
  temporal .. ok
  tickets .. ok
  twkb .. ok
  typmod .. ok
  wkb .. ok
  wkt .. ok
  wmsservers .. ok
  knn_recheck .. ok
  temporal_knn .. ok
  hausdorff .. ok
  regress_buffer_params .. ok
  offsetcurve .. ok
  relatematch .. ok
  isvaliddetail .. ok
  sharedpaths .. ok
  snap .. ok
  node .. ok
  unaryunion .. ok
  clean .. ok
  relate_bnr .. ok
  delaunaytriangles .. ok
  interrupt .. ok
  interrupt_relate .. ok
  interrupt_buffer .. ok
  clipbybox2d .. ok
  subdivide .. ok
  voronoi .. ok
  minimum_clearance .. ok
  in_geojson .. ok
  regress_brin_index .. ok
  regress_brin_index_3d .. ok
  regress_brin_index_geography .. ok
  mvt .. ok
  geobuf .. ok
  mvt_jsonb .. ok
  regress_sfcgal .. ok
  sfcgal/empty .. ok
  sfcgal/geography .. ok
  sfcgal/legacy .. ok
  sfcgal/measures .. ok
  sfcgal/regress_ogc_prep .. ok
  sfcgal/regress_ogc .. ok
  sfcgal/regress .. ok
  sfcgal/tickets .. ok
  sfcgal/concave_hull .. ok
  sfcgal/wmsservers .. ok
  sfcgal/approximatemedialaxis .. ok
  uninstall .. ok (4662)

 Run tests: 135
 Failed: 1

 }}}


 @pramsey,

 I'm leaving this open because not sure I made the right changes.  I was
 following the pattern of other code I saw in PostgreSQL 10.

 In particular, I'm not sure about the flags.  I had originally


 {{{
  ATTSTATSSLOT_VALUES | ATTSTATSSLOT_NUMBERS
 }}}


 as I saw that in src/backend/tsearch/ts_selfuncs.c (tsvector estimates),
 but had to take out the ATTSTATSSLOT_VALUES since it was causing
 regression failure on regress_index and some others.

 A lot of the other sample code in PostgreSQL land has this check like
 this:


 {{{
 if (HeapTupleIsValid(vardata->statsTuple))
 }}}



 I didn't bother with that and not sure if its relevant for us to check.

--
Ticket URL: <https://trac.osgeo.org/postgis/ticket/3758#comment:3>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.