[postgis-tickets] [PostGIS] #3934: comments files missing from tar ball

[PostGIS]

#3934: comments files missing from tar ball
---------------------+---------------------------
 Reporter:  robe     |      Owner:  pramsey
     Type:  defect   |     Status:  new
 Priority:  blocker  |  Milestone:  PostGIS 2.4.3
Component:  postgis  |    Version:  2.4.x
 Keywords:           |
---------------------+---------------------------
 Excerpted from https://lists.osgeo.org/pipermail/postgis-
 devel/2017-November/026731.html

 {{{
 From: postgis-devel [mailto:postgis-devel-bounces at lists.osgeo.org] On
 Behalf Of Tom van Tilburg
 Sent: Thursday, November 23, 2017 4:56 AM
 To: PostGIS Development Discussion <postgis-devel at lists.osgeo.org>
 Subject: [postgis-devel] extensions not building in 2.4.2?

 Doing a fresh build on ubuntu 17.04 with:
 ./autogen.sh
 ./configure

 I expect the extensions directory to be added to GNUMakefile, but it
 doesn't. Same procedure for  2.4.1 *does* build the extensions.
 Looking into the configure.ac, it seems to boil down to:
 EXTENSIONS=""
 if test \
         "x$XSLTPROC" != "x" -o \
         -e doc/postgis_comments.sql -a \
         -e doc/raster_comments.sql;

 then
   if test "x$RASTER" = "xraster"; then
       AC_MSG_RESULT([enabling PostgreSQL extension support...])
       EXTENSIONS=extensions
       AC_SUBST([EXTENSIONS])
   fi
 fi

 This part is the same in 2.4.1 and 2.4.2 and the only thing that I can see
 that changes the outcome is the removal of doc/postgis_comments.sql and
 doc/raster_comments.sql
 from the 2.4.2 distribution.

 Now, since the SQL files were not supposed to be there in the first place
 (they have been put in .gitignore) it seems that all these years I have
 been building extensions illegally and free-riding on the distributed
 comments files (never ran into trouble with it). Is my assumption correct
 that the pre-2.4.2 configuration was wrong? And that I should fix my setup
 to build these comments files in order to get extensions back?

 Best,
  Tom

 }}}

--
Ticket URL: <https://trac.osgeo.org/postgis/ticket/3934>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.