[postgis-tickets] r16124 - Explicitly specify $(PERL) to call create_unpackaged.pl otherwise at least on freebsd it fails (and backport other minor changes like remove of 9.1 which support was dropped in 2.2)

[Regina Obe]

Author: robe
Date: 2017-11-28 17:12:37 -0800 (Tue, 28 Nov 2017)
New Revision: 16124

Added:
   branches/2.3/ci/bessie/
   branches/2.3/ci/bessie/postgis_regress.sh
   branches/2.3/ci/bessie32/
   branches/2.3/ci/bessie32/postgis_regress.sh
Modified:
   branches/2.3/extensions/postgis_sfcgal/Makefile.in
Log:
Explicitly specify $(PERL) to call create_unpackaged.pl otherwise at least on freebsd it fails (and backport other minor changes like remove of 9.1 which support was dropped in 2.2)
Closes #3938 for PostGIS 2.3.6
Also add the Bessie sisters to battery testing

Added: branches/2.3/ci/bessie/postgis_regress.sh
===================================================================
--- branches/2.3/ci/bessie/postgis_regress.sh	                        (rev 0)
+++ branches/2.3/ci/bessie/postgis_regress.sh	2017-11-29 01:12:37 UTC (rev 16124)
@@ -0,0 +1,8 @@
+export PATH=${PATH}:/usr/local:/usr/local/lib:/usr/local/bin
+sh autogen.sh
+./configure --with-projdir=/usr/local --with-libiconv=/usr/local --without-interrupt-tests
+make clean
+make
+export PGUSER=postgres
+export PGIS_REG_TMPDIR=~/tmp/pgis_reg_${TAG}
+make check

Added: branches/2.3/ci/bessie32/postgis_regress.sh
===================================================================
--- branches/2.3/ci/bessie32/postgis_regress.sh	                        (rev 0)
+++ branches/2.3/ci/bessie32/postgis_regress.sh	2017-11-29 01:12:37 UTC (rev 16124)
@@ -0,0 +1,8 @@
+export PATH=${PATH}:/usr/local:/usr/local/lib:/usr/local/bin
+sh autogen.sh
+./configure --with-projdir=/usr/local --with-libiconv=/usr/local --without-interrupt-tests
+make clean
+make
+export PGUSER=postgres
+export PGIS_REG_TMPDIR=~/tmp/pgis_reg_${TAG}
+make check

Modified: branches/2.3/extensions/postgis_sfcgal/Makefile.in
===================================================================
--- branches/2.3/extensions/postgis_sfcgal/Makefile.in	2017-11-29 00:18:54 UTC (rev 16123)
+++ branches/2.3/extensions/postgis_sfcgal/Makefile.in	2017-11-29 01:12:37 UTC (rev 16124)
@@ -26,18 +26,16 @@
 
 PG_CONFIG    =  @PG_CONFIG@
 
-PG91         = $(shell $(PG_CONFIG) --version | $(GREP) -qE " 8\.| 9\.0" && echo no || echo yes)
 SQL_BITS     = $(wildcard sql_bits/*.sql)
-EXTRA_CLEAN += sql/*.sql ${SQL_BITS} 
+EXTRA_CLEAN += sql/*.sql ${SQL_BITS}
 
 
-ifeq ($(PG91),yes)
 all: sql/$(EXTENSION)--$(EXTVERSION).sql sql/$(EXTENSION)--unpackaged--$(EXTVERSION).sql sql/$(EXTENSION)--$(EXTVERSION)--$(EXTVERSION)next.sql sql/$(EXTENSION)--$(EXTVERSION)next--$(EXTVERSION).sql sql_minor_upgrade
 
 sql/$(EXTENSION)--$(EXTVERSION).sql: sql/$(EXTENSION).sql
 	mkdir -p sql
 	cp $< $@
-	
+
 sql/$(EXTENSION).sql: sql_bits/sfcgal.sql  sql_bits/sfcgal_comments.sql
 	mkdir -p sql
 	cat $^ > $@
@@ -66,7 +64,7 @@
 #then remove default values and extra junk
 sql/$(EXTENSION)--unpackaged--$(EXTVERSION).sql: sql_bits/sfcgal.sql ../../utils/create_unpackaged.pl
 	mkdir -p sql
-	cat $< | ../../utils/create_unpackaged.pl ${EXTENSION} > $@
+	cat $< |  $(PERL) ../../utils/create_unpackaged.pl ${EXTENSION} > $@
 
 sql_bits/sfcgal_upgrade.sql : ../../postgis/sfcgal_upgrade.sql
 	mkdir -p sql_bits
@@ -74,17 +72,16 @@
 
 sql_bits/sfcgal_upgrade_minor.sql: ../postgis_extension_helper.sql sql_bits/sfcgal_upgrade.sql ../../doc/sfcgal_comments.sql ../postgis_extension_helper_uninstall.sql
 	mkdir -p sql_bits
-	echo '\echo Use "CREATE EXTENSION $(EXTENSION)" to load this file. \quit' > $@
+	printf '\\echo Use "CREATE EXTENSION $(EXTENSION)" to load this file. \\quit\n' > $@
 	cat $^ >> $@
 
 sql_minor_upgrade: sql_bits/sfcgal_upgrade_minor.sql
 	for OLD_VERSION in $(UPGRADEABLE_VERSIONS); do \
   	  cat $< > sql/$(EXTENSION)--$$OLD_VERSION--$(EXTVERSION).sql; \
 	done
-	
+
 DATA = $(wildcard sql/*--*.sql)
 EXTRA_CLEAN += sql/$(EXTENSION)--$(EXTVERSION).sql sql/$(EXTENSION)--unpackaged--$(EXTVERSION).sql
-endif
 
 distclean: clean
 	rm Makefile