[postgis-tickets] [PostGIS] #3956: Upgrade does not upgrade geog_brin_inclusion_add_value function to use the updated module

[PostGIS]

#3956: Upgrade does not upgrade geog_brin_inclusion_add_value function to use the
updated module
-----------------------+---------------------------
  Reporter:  keiko713  |      Owner:  robe
      Type:  defect    |     Status:  new
  Priority:  medium    |  Milestone:  PostGIS 2.4.3
 Component:  postgis   |    Version:  2.4.x
Resolution:            |   Keywords:
-----------------------+---------------------------

Comment (by robe):

 keiko713,

 Which version of PostgreSQL/PostGIS were you coming from?  Please provide
 output of


 {{{
 SELECT postgis_full_version() || ' ' || version();
 }}}

 on both your old and new cluster.


   I'm looking at the latest upgrade script, and for PostgreSQL 9.5 and
 above, the geog_brin_inclusion_add_value  function is always updated as is
 the case with all functions.

 So the only reason why I can think this would have failed for you is 2

 1) You are using scripts that were compiled against PostgreSQL 9.4 or
 below  to upgrade your database.  The IF def is there to prevent these
 functions and types from being installed.  So if you are using these
 upgrade scripts, yah these functions won't be in there.

 strk - I forget, did we put in a check in 2.4 to prevent someone from
 accidentally using scripts compiled against a lower version of PostgreSQL
 on a higher version of PostgreSQL.  If we did that would have caught this
 case.

 2) You are using a PostGIS micro before 2.3.3. I think then though, you
 would have had issues as the upgrade script would include trying to
 upgrade types you didn't have and you would have had to manually install
 these to correct the situation as your upgrade would have failed.

--
Ticket URL: <https://trac.osgeo.org/postgis/ticket/3956#comment:5>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.