[postgis-tickets] r16254 - Formatting only before toucing Encoded Polyline logic.

Sandro Santilli strk at kbt.io
Thu Jan 11 07:14:35 PST 2018


On Thu, Jan 11, 2018 at 03:09:26PM +0000, Darafei "Komяpa" Praliaskouski wrote:
> >
> > > Formatting only before toucing Encoded Polyline logic.
> >
> > I see you changed many lines from wrapping to single-lined.
> > Why so ? Staying within 80 columns is intentional...
> >
> 
> Original code wasn't always fitting into 80 columns - I see a 132-char line.
> Now it at least fits to 120. We have a set of lines longer than 80 already
> :)

Not a good reason to make it worst, IMHO

> It also occurs to me that some copyrights in lwout_encoded_polyline.c,
> judging by hanging ...and on line - Kashif, is that a stray `and` or a lost
> author?
> 
> >>> Copyright 2014 Kashif Rasul <kashif.rasul at gmail.com> and

It's been 4 years, if Kashif does not answer just drop the "and"
(or check NEWS file)

--strk;


More information about the postgis-tickets mailing list