[postgis-tickets] r17015 - Allocate enough memory in gidx_to_string

[Raul]

Author: algunenano
Date: 2018-11-15 01:04:17 -0800 (Thu, 15 Nov 2018)
New Revision: 17015

Modified:
   branches/2.2/NEWS
   branches/2.2/libpgcommon/gserialized_gist.c
Log:
Allocate enough memory in gidx_to_string

References #4236



Modified: branches/2.2/NEWS
===================================================================
--- branches/2.2/NEWS	2018-11-14 13:38:10 UTC (rev 17014)
+++ branches/2.2/NEWS	2018-11-15 09:04:17 UTC (rev 17015)
@@ -10,6 +10,7 @@
    - #4203, Fix build with GNU Make 4.1 (Sandro Santilli)
    - #4206, Fix support for PostgreSQL 12 dev branch (Laurenz Albe)
    - #3457, Fix raster envelope shortcut in ST_Clip (Sai-bot)
+   - #4326, Allocate enough memory in gidx_to_string (Raúl Marín)
 
 
 PostGIS 2.2.7

Modified: branches/2.2/libpgcommon/gserialized_gist.c
===================================================================
--- branches/2.2/libpgcommon/gserialized_gist.c	2018-11-14 13:38:10 UTC (rev 17014)
+++ branches/2.2/libpgcommon/gserialized_gist.c	2018-11-15 09:04:17 UTC (rev 17015)
@@ -35,8 +35,13 @@
 
 	if ( a == NULL )
 		return pstrdup("<NULLPTR>");
-
-	str = (char*)palloc(128); /* 15*2*4+8==128 */
+	/* 4 (GIDX_MAX_DIM) *
+	 * 2 (MAX & MIN) *
+	 * 20 (Max representation (e.g. -3.40282346639e+38) [19] + space)
+	 * = 4*2*20 = 160
+	 * + 9 [ 'GIDX(' = 5, ','  = 1, ' )' = 2 + '\0' = 1]
+	 */
+	str = (char *)palloc(169);
 	rv = str;
 	ndims = GIDX_NDIMS(a);