[postgis-tickets] r17017 - Allocate enough memory in gidx_to_string

[Raul]

Author: algunenano
Date: 2018-11-15 01:06:12 -0800 (Thu, 15 Nov 2018)
New Revision: 17017

Modified:
   branches/2.4/NEWS
   branches/2.4/libpgcommon/gserialized_gist.c
Log:
Allocate enough memory in gidx_to_string

References #4236



Modified: branches/2.4/NEWS
===================================================================
--- branches/2.4/NEWS	2018-11-15 09:05:32 UTC (rev 17016)
+++ branches/2.4/NEWS	2018-11-15 09:06:12 UTC (rev 17017)
@@ -16,6 +16,7 @@
   - #4216, Return to slicing for bbox access in gserialized (Paul Ramsey)
   - #4136, Proper repeated point removal on small polygons (Paul Ramsey)
   - #4223, ST_DistanceTree error for near parallel boxes (Paul Ramsey)
+  - #4326, Allocate enough memory in gidx_to_string (Raúl Marín)
 
 
 PostGIS 2.4.5

Modified: branches/2.4/libpgcommon/gserialized_gist.c
===================================================================
--- branches/2.4/libpgcommon/gserialized_gist.c	2018-11-15 09:05:32 UTC (rev 17016)
+++ branches/2.4/libpgcommon/gserialized_gist.c	2018-11-15 09:06:12 UTC (rev 17017)
@@ -35,8 +35,13 @@
 
 	if ( a == NULL )
 		return pstrdup("<NULLPTR>");
-
-	str = (char*)palloc(128); /* 15*2*4+8==128 */
+	/* 4 (GIDX_MAX_DIM) *
+	 * 2 (MAX & MIN) *
+	 * 20 (Max representation (e.g. -3.40282346639e+38) [19] + space)
+	 * = 4*2*20 = 160
+	 * + 9 [ 'GIDX(' = 5, ','  = 1, ' )' = 2 + '\0' = 1]
+	 */
+	str = (char *)palloc(169);
 	rv = str;
 	ndims = GIDX_NDIMS(a);