[postgis-tickets] [PostGIS] #4311: MVT: Introduce wagyu to clip and validate polygon
PostGIS
trac at osgeo.org
Fri Feb 1 02:10:37 PST 2019
#4311: MVT: Introduce wagyu to clip and validate polygon
--------------------------+---------------------------
Reporter: Algunenano | Owner: pramsey
Type: enhancement | Status: new
Priority: medium | Milestone: PostGIS 3.0.0
Component: postgis | Version: trunk
Resolution: | Keywords:
--------------------------+---------------------------
Comment (by Algunenano):
> It looks like we are including wagyu code in our code base. Is that
correct or am I misreading? If so what's the reasoning behind that instead
just having a wget call or something.
A little of backstory: Initially I considered the idea of using system
packages for it, but only some distro's distribute it (no OSX, Windows...)
and even the ones that do won't have the latest changes that I had to do
to integrate it with Postgis. Those changes are now merged upstream but
there isn't a release with it.
My second option would have been to use `git submodules`; I'm not a big
fan of them but they are available wherever you have git. The equivalent
for svn seems to be ` svn:externals` but I certainly don't want to deal
with mixing Wagyu's `git` with our `svn`.
Now that all the changes are merged upstream, using something like `wget`
is an option. But thinking about it, it means downloading 2 projects (it
uses `geometry.hpp` and `wagyu`), validate them (shaXX) and keeping them
up to date when you run either `autogen.sh` or `configure`. I don't expect
many updates from upstream, but some might happen and doing package /
source validation using autotools in a portable way seems extremely hard.
The last option I could come up with was to push the sources into a
directory in Postgis. It isn't great since, as you say, it's easy to
deviate from the main project but it will work for everyone no matter what
OS they're running. The nice part is that to update the libraries, at
least right now, you just need to copy and paste the include folder from
the 2 projects into `deps/wagyu` and you are done.
--
Ticket URL: <https://trac.osgeo.org/postgis/ticket/4311#comment:2>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.
More information about the postgis-tickets
mailing list