[postgis-tickets] [PostGIS] #4313: PostgreSQL commits a9c35cf85ca and fa2cf164aaf break build

[PostGIS]

#4313: PostgreSQL commits a9c35cf85ca and fa2cf164aaf break build
-----------------------------------+---------------------------
 Reporter:  Laurenz Albe           |      Owner:  strk
     Type:  defect                 |     Status:  new
 Priority:  medium                 |  Milestone:  PostGIS 2.5.2
Component:  build/upgrade/install  |    Version:  trunk
 Keywords:                         |
-----------------------------------+---------------------------
 Commit
 [https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=fa2cf164aaf91e074be653c28e035f65d80eb666
 fa2cf164aaf91e074be653c28e035f65d80eb666] renamed `nodes/relation.h` to
 `nodes/pathnodes.h`.

 This affects `postgis/gserialized_estimate.c` and is easily fixed by the
 attached patch.

 Commit
 [https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=a9c35cf85ca1ff72f16f0f10d7ddee6e582b62b8
 a9c35cf85ca1ff72f16f0f10d7ddee6e582b62b8] is a more difficult affair.

 It removed `FunctionCallInfoData` and replaced it with a variable-length
 array that is allocated with the `LOCAL_FCINFO` macro. The way to access
 the function arguments has also changed.

 My attached patch is an attempt to fix all places (which are unfortunately
 many). This certainly makes the code harder to read.

 There are some files where my changes are pretty invasive, mostly
 `raster/rt_pg/rtpg_mapalgebra.c`. This would require an extra pair of eyes
 and some testing.

 Of course it would be nice to reduce the number of sites in the code where
 direct function calls are made.

-- 
Ticket URL: <https://trac.osgeo.org/postgis/ticket/4313>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.